feat: expose hideBin helper for CJS#1768
Merged
Merged
Conversation
roryokane
reviewed
Sep 26, 2020
roryokane
left a comment
roryokane
left a comment
Contributor
There was a problem hiding this comment.
Here is my feedback on this PR’s documentation changes. I don’t know Yargs internals well enough to comment on the code changes, beyond saying I don’t see anything obviously wrong in the diff.
Co-authored-by: Rory O’Kane <rory@roryokane.com>
Co-authored-by: Rory O’Kane <rory@roryokane.com>
Co-authored-by: Rory O’Kane <rory@roryokane.com>
Co-authored-by: Rory O’Kane <rory@roryokane.com>
This was referenced Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
hideBinhelper for CJS, so that we can standardize the documentation for ESM, CJS, and Deno.Updates documentation to suggest this approach by default.
Fixes #1648
TODO: update the rest of the examples in the documentation.