fix(data): Make CodeDesc.code optional - #343
Merged
Merged
Conversation
Some play-by-play code description pairs come back from the api without a code. In game 777961 allPlays->68->playEvents->0->type has a description of "Unknown" and no code, so getting the play-by-play data fails on the required argument. Default to None instead. Fixes zero-sum-seattle#342
louisadamian
changed the title
Member
|
Okay let me take a look at this one man |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some play-by-play code description pairs come back from the api without a code. In game 777961 allPlays->68->playEvents->0->type has a description of "Unknown" and no code, so getting the play-by-play data fails on the required argument. Default to None instead.
Fixes #342