Skip to content

feat(rt): allow customizing any async runtime adapter - #1192

Draft
0x676e67 wants to merge 27 commits into
mainfrom
conn
Draft

feat(rt): allow customizing any async runtime adapter#1192
0x676e67 wants to merge 27 commits into
mainfrom
conn

Conversation

@0x676e67

@0x676e67 0x676e67 commented Jun 1, 2026

Copy link
Copy Markdown
Owner

close: #1115

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the runtime glue and connection management of the client by introducing a unified RuntimeHandle that consolidates task execution, timers, DNS resolution, and connection capabilities, while removing custom connector implementations in favor of wreq-rt traits. The code review highlights three main areas for improvement: first, the conditional compilation of builder and new should be refactored to always-available builder_with_runtime and with_runtime methods to prevent them from being compiled out due to Cargo's additive features; second, the temporary git branches in the [patch.crates-io] section of Cargo.toml must be removed before merging to ensure crates.io publishing is not broken; and third, a doc comment in src/dns/resolve.rs should be updated to correctly state that into_inner returns an owned Box<str> instead of a string slice.

Comment thread src/client.rs
Comment thread Cargo.toml Outdated
Comment thread src/dns/resolve.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow pluggable TCP/UDP connector

1 participant