Skip to content

Change metrics-bind-address default to 0 (disabled) Fixes #214#279

Open
yashpy wants to merge 1 commit into
1Password:mainfrom
yashpy:fix/metrics-bind-address-default
Open

Change metrics-bind-address default to 0 (disabled) Fixes #214#279
yashpy wants to merge 1 commit into
1Password:mainfrom
yashpy:fix/metrics-bind-address-default

Conversation

@yashpy

@yashpy yashpy commented Jul 24, 2026

Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings July 24, 2026 17:51
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the default value for the controller-runtime --metrics-bind-address flag to disable metrics by default (setting it to "0"), aligning the binary’s default behavior with the documented “0 disables metrics” option and reducing the chance of unintentionally exposing a metrics endpoint when the flag isn’t explicitly set.

Changes:

  • Set --metrics-bind-address default from :8080 to 0 (disabled by default).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yashpy
yashpy force-pushed the fix/metrics-bind-address-default branch from 9b4e323 to 7621d7d Compare July 24, 2026 17:57
@yashpy
yashpy force-pushed the fix/metrics-bind-address-default branch from 7621d7d to 7820076 Compare July 24, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants