Чтение характеристик - #668
Merged
Merged
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a ChangesObject characteristics support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MetadataXML
participant CharacteristicConverter
participant Characteristic
participant MetadataObject
MetadataXML->>CharacteristicConverter: provide characteristic nodes
CharacteristicConverter->>Characteristic: map fields to MdoReference values
CharacteristicConverter->>MetadataObject: return characteristic collection
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/github/_1c_syntax/bsl/mdo/CharacteristicOwner.java`:
- Line 35: Declare nullness consistently across the characteristics model:
update getCharacteristics() in CharacteristicOwner.java and the affected
List<Characteristic>/MdoReference members in Characteristic.java (lines 43-104),
BusinessProcess.java (235-236), Catalog.java (319-320), ChartOfAccounts.java
(269-270), ChartOfCalculationTypes.java (234-235), and
ChartOfCharacteristicTypes.java (301-302 and 304-308). Use `@NonNull` for values
that are always present, or `@Nullable` where absence is intentional, matching the
existing project annotations.
In `@src/main/java/com/github/_1c_syntax/bsl/mdo/storage/Characteristic.java`:
- Around line 36-37: Update the EqualsAndHashCode configuration on
Characteristic to include every field that defines a characteristic description,
not only characteristicTypes and characteristicValues; ensure mappings differing
in key, object, type, or value fields compare as unequal while preserving the
existing string representation configuration.
- Around line 43-44: Annotate the characteristicTypes field with JSpecify
org.jspecify.annotations.NonNull because it defaults to MdoReference.EMPTY and
is not nullable; use `@Nullable` only if this field can intentionally receive
null.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d40de3f7-3298-49de-b81b-152accc6959d
⛔ Files ignored due to path filters (33)
src/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Catalogs.Справочник1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfAccounts.ПланСчетов1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfCalculationTypes.ПланВидовРасчета1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Documents.Документ1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Enums.Перечисление1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/ExchangePlans.ПланОбмена1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Tasks.Задача1.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_18/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_25/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_3_27/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_5_1/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses_ext/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Catalogs.ВерсииФайлов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Catalogs.Заметки.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Documents.Анкета.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Enums.СтатусыОбработчиковОбновления.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/BusinessProcesses.Задание.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Catalogs.ВерсииФайлов.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Catalogs.Заметки.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Documents.Анкета.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Enums.СтатусыОбработчиковОбновления.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/ExchangePlans.ОбновлениеИнформационнойБазы.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/ssl_3_2/Tasks.ЗадачаИсполнителя.jsonis excluded by!src/test/resources/**
📒 Files selected for processing (14)
src/main/java/com/github/_1c_syntax/bsl/mdo/BusinessProcess.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/CharacteristicOwner.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfAccounts.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCalculationTypes.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Document.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Enum.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/ExchangePlan.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/Task.javasrc/main/java/com/github/_1c_syntax/bsl/mdo/storage/Characteristic.javasrc/main/java/com/github/_1c_syntax/bsl/reader/designer/converter/CharacteristicConverter.javasrc/main/java/com/github/_1c_syntax/bsl/reader/edt/converter/CharacteristicConverter.javasrc/test/java/com/github/_1c_syntax/bsl/mdo/CharacteristicOwnerTest.java
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Реализовано чтение описания характеристик объектов метаданных
Связанные задачи
Closes #655
Чеклист
Общие
gradlew precommit)Дополнительно
Summary by CodeRabbit