Skip to content

Adds info in the issue list about who needs to be called, before the first call is made#298

Open
dektar wants to merge 5 commits intomasterfrom
issueCallInfo
Open

Adds info in the issue list about who needs to be called, before the first call is made#298
dektar wants to merge 5 commits intomasterfrom
issueCallInfo

Conversation

@dektar
Copy link
Copy Markdown
Collaborator

@dektar dektar commented Mar 29, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization

Description

When no location, shows the areas to call. When a location is set but no calls made yet, shows the number of calls and the areas (removes areas that can't be called, like senators removed from DC which has none). When any calls have been made, leaves text as it was because "N calls to call today" has been effective and people may already remember the contact areas.

Contact Areas -> String logic is taken from the iOS app.

Improves the extra tall lines from showing the bookmarks icon even before a location is set

DC example handling 1 or 0:
image

California example:
image

Were the changes tested?

  • Yes, automated tests in IssueAdapterTest
  • Yes, manually tested: No location, California and DC, with 0, 1 or all calls completed. In Spanish and English to double-check no crashing from string formatting changes.
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

dektar added 4 commits March 28, 2026 18:22
This is shown before any calls are made for an issue, or if there is no location set
@dektar dektar requested a review from scottpeterson March 29, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants