Adds info in the issue list about who needs to be called, before the first call is made#298
Open
Adds info in the issue list about who needs to be called, before the first call is made#298
Conversation
This is shown before any calls are made for an issue, or if there is no location set
5calls/app/src/main/java/org/a5calls/android/a5calls/adapter/IssuesAdapter.java
Outdated
Show resolved
Hide resolved
5calls/app/src/main/java/org/a5calls/android/a5calls/adapter/IssuesAdapter.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When no location, shows the areas to call. When a location is set but no calls made yet, shows the number of calls and the areas (removes areas that can't be called, like senators removed from DC which has none). When any calls have been made, leaves text as it was because "N calls to call today" has been effective and people may already remember the contact areas.
Contact Areas -> String logic is taken from the iOS app.
Improves the extra tall lines from showing the bookmarks icon even before a location is set
DC example handling 1 or 0:

California example:

Were the changes tested?
have not been included