Skip to content

Migrated to version catalog#299

Open
scottpeterson wants to merge 1 commit intomasterfrom
version-catalog
Open

Migrated to version catalog#299
scottpeterson wants to merge 1 commit intomasterfrom
version-catalog

Conversation

@scottpeterson
Copy link
Copy Markdown
Collaborator

kept all versions the same

Decisions made to keep the changeset small

  1. Stayed with Groovy DSL
  2. Did not migrate plugins
  3. Left root build.gradle structure as-is
  4. Left fileTree as-is
  5. Firebase BOM pattern preserved
  6. Kept ext.kotlin_version in root build.gradle

Potential future improvements

  1. Modernize root build structure
  2. Add a [plugins] section
  3. Convert to Kotlin DSL
  4. Move ext.kotlin_version into the version catalog
  5. Add more bundles
  6. Remove fileTree
  7. Remove android.enableJetifier=true from gradle.properties

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization

Description

Related Issues

  • Related Issue #
  • Closes #

Were the changes tested?

  • Yes, automated tests in please name test methods or files
  • Yes, manually tested: please provide steps performed to test changes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

kept all versions the same
@scottpeterson scottpeterson requested a review from dektar March 29, 2026 20:53
@dektar
Copy link
Copy Markdown
Collaborator

dektar commented Mar 30, 2026

Could you explain why we should do this migration -- what's the benefit? I found this reddit post (so I didn't do "deep" research) that made it seem like it might not be necessary for our little project.

We can discuss in Slack or here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants