Skip to content

Fix Windows CLI package launch#28

Open
Iydah wants to merge 3 commits into
851-labs:mainfrom
Iydah:codex/fix-cli-windows-install
Open

Fix Windows CLI package launch#28
Iydah wants to merge 3 commits into
851-labs:mainfrom
Iydah:codex/fix-cli-windows-install

Conversation

@Iydah

@Iydah Iydah commented Jul 2, 2026

Copy link
Copy Markdown

what changed

  • fixed the Windows npm and Bun global shim issue by making the package bin point at the JS launcher instead of the native exe
  • moved the main package writer into a small shared helper so tests can cover the generated package without importing the Bun publish runtime
  • made the CLI build script work on Windows by moving the chmod bit into a Bun script
  • cleaned up service path handling so launchd and systemd paths keep POSIX slashes, while Windows service paths keep Windows slashes
  • split a couple slow or shared-lock tests so the full turbo test run is more stable
  • added dependency overrides for esbuild and undici so bun audit is clean without doing a broad dependency upgrade

checked

  • bun audit
  • bun run typecheck
  • bun run test
  • bun run lint
  • bun run fmt
  • bun run build
  • bun apps/cli/script/build-service-runners.ts --single --out-dir , then ran the generated Windows runner with --version
  • packed the generated CLI package and installed it through temp npm and Bun global prefixes, then ran tokenmaxxing --version through both shims

@Iydah Iydah marked this pull request as ready for review July 2, 2026 21:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40cd9bfcd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

repository: packageJson.repository,
bin: {
tokenmaxxing: "./bin/tokenmaxxing.exe",
tokenmaxxing: "./native-bin-launcher.cjs",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore installer fallback for skipped optional deps

When optionalDependencies are omitted/skipped but lifecycle scripts still run, install-native.mjs materializes the downloaded host binary at bin/tokenmaxxing.exe, but this new bin target invokes native-bin-launcher.cjs instead. The launcher only resolves the optional native packages and never checks the materialized bin/tokenmaxxing.exe, so installs that succeeded via the preinstall fallback now fail at runtime with the recovery message. Either keep the bin pointed at the installed fallback or teach the launcher to use it when native packages are absent.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant