Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add utils to manipulate the NNX shardings with abstract state of a model
also add unit tests for the utils
Extract mesh creation function to maxtext_utils.get_mesh_from_config()
also add unit tests for this func
Note:
flax v0.12 has DeprecationWarning in multiple places:
But since the code needs to work with post-training, which currently requires flax v0.11, we didn't change code for these warnings.
Tests
Since there is minor change in the create_nnx_model() code, verified the SFT in single node with stable dependencies and it passed.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.