move src/MaxText/configs to src/maxtext/configs #3044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khatwanimohit
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
khatwanimohit
force-pushed
the
mohit/move_configs
branch
5 times, most recently
from
69a42de to
ab4e2e0
Compare
khatwanimohit
requested review from
A9isha,
Lumosis,
NuojCheng,
Obliviour,
RissyRan,
SujeethJinesh,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
jacoguzo,
jiangjy1982,
jrplatin,
mailvijayasingh,
mitalisi,
notabee,
patemotter,
richjames0,
shauryagup,
shralex,
suexu1025 and
vipannalla
as code owners
khatwanimohit
requested review from
NicoGrande,
SurbhiJainUSC,
aireenmei,
hengtaoguo,
jesselu-google,
parambole and
shuningjin
as code owners
khatwanimohit
force-pushed
the
mohit/move_configs
branch
10 times, most recently
from
4ca3926 to
ff7bbe7
Compare
| "from maxtext.trainers.post_train.sft import train_sft\n", | ||
| "import jax\n", | ||
| "from huggingface_hub import login\n", | ||
| "from MaxText.globals import MAXTEXT_REPO_ROOT\n", |
Collaborator
There was a problem hiding this comment.
Why do we need this import?
Collaborator
Author
There was a problem hiding this comment.
earlier we got MAXTEXT_REPO_ROOT like this MAXTEXT_REPO_ROOT = os.path.dirname(MaxText.__file__). I removed that line and added this import because that line points to the MaxText folder which I don't want
NuojCheng
reviewed
Jan 31, 2026
NuojCheng
approved these changes
Jan 31, 2026
khatwanimohit
force-pushed
the
mohit/move_configs
branch
3 times, most recently
from
2f94449 to
92b299e
Compare
khatwanimohit
force-pushed
the
mohit/move_configs
branch
from
92b299e to
23be6e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move src/MaxText/configs to src/maxtext/configs
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Github CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.