-
Notifications
You must be signed in to change notification settings - Fork 458
Restructure input_pipeline and migrate to src/maxtext #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8905df5 to
99f69ca
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
8cf1adb to
0faa654
Compare
0faa654 to
9b4fdb2
Compare
4b3ea13 to
68e1ad6
Compare
|
🤖 Hi @hengtaoguo, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
hengtaoguo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Browsed through all the files and looks like a solid restructure and relocation. Are there any edge cases which could not be covered by the CI? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This pull request effectively restructures the input pipeline by migrating it to src/maxtext and organizing it into submodules. The changes are consistent and well-executed across the entire codebase, including examples, tests, and tools.
🔍 General Feedback
- The refactoring significantly improves the project structure and modularity of the input pipeline.
- All import paths have been updated correctly to reflect the new structure.
- Renaming files by removing the leading underscore is a good cleanup practice that enhances clarity.
As this is mainly restructure and migration, nothing new is added, the existing CI test should be sufficient to make sure no import errors. |
68e1ad6 to
9ae7e45
Compare
Description
Restructure the input pipeline folder as follows:
under src/maxtext:
input_pipeline
Makes corresponding changes in imports
Tests
CI test
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.