Skip to content

Conversation

@dipannita08
Copy link
Collaborator

@dipannita08 dipannita08 commented Jan 30, 2026

Description

Move src/MaxText/layers to src/maxtext/layers.

Tests

  • Unit tests
  • Github CI

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 96.06742% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/encoders.py 33.33% 4 Missing ⚠️
src/MaxText/integration/tunix/tunix_adapter.py 0.00% 1 Missing ⚠️
src/MaxText/layerwise_quantization.py 0.00% 1 Missing ⚠️
src/MaxText/utils/ckpt_conversion/to_maxtext.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved to src/maxtext/models along with other models modules: https://screenshot.googleplex.com/tq9zWqrLQ7ASYhE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants