Fix the cast for the BITSTREAM_PROFILE profile var#5113
Merged
urvangjoshi merged 1 commit intoJul 15, 2026
Conversation
In the av2_check_profile_interop_conformance() function, the local variable `profile` is of the BITSTREAM_PROFILE type, so it is redundant to cast `profile` to BITSTREAM_PROFILE. I suspect the intended cast is `int`, to match the %d printf format specifier. Alternatively, we can simply remove the BITSTREAM_PROFILE casts.
wantehchang
commented
Jul 14, 2026
urvangjoshi
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the av2_check_profile_interop_conformance() function, the local variable
profileis of the BITSTREAM_PROFILE type, so it is redundant to castprofileto BITSTREAM_PROFILE. I suspect the intended cast isint, to match the %d printf format specifier.Alternatively, we can simply remove the BITSTREAM_PROFILE casts.