Rework av2_encode_block_intra_joint_uv#5118
Merged
Merged
Conversation
jingninghan
requested review from
jianle973,
kslu-aom,
leolzhao,
urvangjoshi and
yeqing-wu
July 16, 2026 17:45
Contributor
|
Will wait for your review @kslu-aom . |
kslu-aom
reviewed
Jul 16, 2026
kslu-aom
approved these changes
Jul 16, 2026
yeqing-wu
reviewed
Jul 16, 2026
yeqing-wu
reviewed
Jul 16, 2026
jingninghan
force-pushed
the
txfm2
branch
2 times, most recently
from
July 16, 2026 21:22
0f9010d to
4267e22
Compare
Make it properly handle cctx cases. Take out coeff dropout to be consistent with what's used in RD search stage. Re-do u plane if its eob is different from that's in RD search to avoid potential mismatch issues due to the change of cctx_type. Tested for A2 and A4 in speed 1 with 33 frames. No coding stats change observed.
yeqing-wu
approved these changes
Jul 16, 2026
leolzhao
enabled auto-merge (squash)
July 16, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it properly handle cctx cases.
Take out coeff dropout to be consistent with what's used in RD search stage.
Re-do u plane if its eob is different from that's in RD search to avoid potential mismatch issues due to the change of cctx_type.
Tested for A2 and A4 in speed 1 with 33 frames. No coding stats change observed.