fix: rebuild dist so action uses GitHub Models endpoint - #4
Open
aryanorastar wants to merge 1 commit into
Open
Conversation
action.yml runs dist/index.js, which was still calling the deprecated Azure Models URL while src already targeted models.github.ai. Rebuild with ncc so prompt/advanced modes match current source.
Contributor
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2
action.ymlpoints atdist/index.js, but that bundle was stale: it still called the deprecated Azure Models endpoint (models.inference.ai.azure.com) whilesrc/agent.jsalready targetsmodels.github.ai/inference/chat/completions. That leftprompt/advancedmodes broken for anyone running the published action.This PR only rebuilds
dist/from currentsrc/(npm ci && npm run build/ncc).Verification
dist/index.jscontainedhttps://models.inference.ai.azure.com/chat/completionshttps://models.github.ai/inference/chat/completionsis presentnpm test— 15/15 passedHonest gaps