fix(tests): isolate pytest from global config and cover both discover… - #324
Merged
rosspeili merged 1 commit intoSep 1, 2026
Merged
Conversation
…y modes Add autouse SKILLWARE_CONFIG_DIR isolation in tests/conftest.py so local pytest matches CI after operator mail/config init. Rename legacy-order tests and add configured-mode coverage for project -> external -> bundled resolution. Fixes ARPAHLS#302
This was referenced Sep 1, 2026
Closed
mrmasa88
added a commit
to 0x-AO-Protocol/skillware
that referenced
this pull request
Sep 1, 2026
Adds the monitoring_kpi_gate row and monitoring category entry to docs/usage/install_extras.md, fills the local-execute column of the agent-loops matrix with the demo script, adds the Runnable examples subsection to the catalog page, and switches the demo to the bundle-class instantiation used by the catalog snippets. Rebased onto current main (ARPAHLS#324); the Unreleased changelog keeps every main-side entry with only the kpi_gate line added. Refs ARPAHLS#317
rosspeili
pushed a commit
that referenced
this pull request
Sep 1, 2026
…interface (#318) * Add the monitoring/kpi_gate skill bundle implementing the issue #317 interface. The bundle evaluates a metrics snapshot against an operator-maintained policy charter and optional versioned benchmark data, returning error, warning, and insufficient_data findings with fail-closed contract errors from a closed registry. Validation follows the four-stage order frozen in issue #317, uses stdlib checks only (requirements stay empty), and ships the three reference JSON Schemas, demo benchmark data, end-to-end and fail-closed fixtures, 28 offline bundle tests, and the card UI schema fixture. Refs #317 * Document the monitoring/kpi_gate skill across the catalog and registry indexes. Adds the catalog page with version metadata, the closed error registry, usage examples for all five providers, and an initial skill history row; adds the index row in docs/skills/README.md, the reference-scripts matrix row in docs/usage/agent_loops.md, the CHANGELOG entry under Unreleased, and the generated monitoring_kpi_gate extras line from scripts/sync_extras.py. Refs #317 * Address the review feedback on the monitoring/kpi_gate bundle. Rewrites the instructions.md opening to the skill-context style used by the other monitoring skills (registry ID, deterministic contract, limits) instead of a persona-style opener; exports KpiGateSkill from the package __init__; adds the offline local-execute demo examples/kpi_gate_demo.py with its CI smoke row and examples index entry. Repo-wide black and flake8 pass with no changes outside the bundle. Refs #317 * Address the second review round on the monitoring/kpi_gate bundle. Adds the monitoring_kpi_gate row and monitoring category entry to docs/usage/install_extras.md, fills the local-execute column of the agent-loops matrix with the demo script, adds the Runnable examples subsection to the catalog page, and switches the demo to the bundle-class instantiation used by the catalog snippets. Rebased onto current main (#324); the Unreleased changelog keeps every main-side entry with only the kpi_gate line added. Refs #317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302.
Local
pytest tests/could fail after normal CLI setup (e.g.skillware mail signature init) when a globalconfig.yamlexists. CI stayed green on a clean home directory; two discovery/loader tests only asserted legacy resolution order.Changes:
SKILLWARE_CONFIG_DIRisolation intests/conftest.pyproject → external → bundled)docs/TESTING.mdanddocs/contributing/ai_native_workflow.mdTest/docs only — no runtime or semver behavior change.
Type of Change
Checklist (all PRs)
Fixes #302)python -m black --check .andflake8pass locally (or CI-equivalent subset)pytest skills/andpytest tests/pass locally when relevant (518 passed)CHANGELOG.mdupdated under[Unreleased]when user-visible behavior changesexamples/README.mdupdated if this PR adds, renames, or removes a runnable script (N/A)pytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changed (N/A)Related Issues
Fixes #302 — supersedes stalled community attempts in #303 and #311.