Repository navigation
feat(wallet_screening): schema v2 verdicts and hop-1 exposures (#439) - #447
Merged
rosspeili merged 1 commit intoOct 20, 2026
Conversation
…LS#439) Add deterministic risk tiers, verdict/risk_factors, and hop-1 sanctions screening while dual-emitting risk_flag for v1 hosts.
rosspeili
approved these changes
Oct 20, 2026
rosspeili
left a comment
Contributor
There was a problem hiding this comment.
@Hendobox this LGTM! Thanks.
My only comments would be, is this the right time to bump the skill to v2? it's ok if you did it on purpose and next slice will be the last but won't change the version, eg. keep next slices also v2 to avoid drift. or v2.x.x.
Also in instructions, no need for the host/agent to know the schema v2, the summarization line could stay as it was, but again, minor and non blocking, we can you think about these and patch in next slice if needed.
Will merge this as is. <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slice 2 of #439: bump
finance/wallet_screeningto 2.0.0 with report schema v2 (verdict,risk_factors, hop-1indirect_exposures/risky_counterparties) while dual-emittingsummary.risk_flagandsummary.total_transactionsfor v1 hosts.Acceptance criteria → diff:
compute_risk_level()matrix (critical/high/medium/low → DENY/REVIEW/ALLOW) →skills/finance/wallet_screening/skill.py; covered bytest_compute_risk_level_matrixintest_skill.py_collect_indirect_exposures; covered bytest_hop1_sanctioned_counterparty_is_high_denyschema_version,verdict,risk_factors, aliases) →_generate_report_data; covered bytest_execute_success, tornado / internal flags,test_direct_sanctions_hit_is_critical_denymanifest.yaml2.0.0,docs/skills/finance/wallet_screening.md(+ hubs),card.json,instructions.md, CHANGELOG[Unreleased]; skill-history Commit cell isTBD(no local SHA)tests/fixtures/card_ui_schema/finance__wallet_screening.jsonOut of this PR (later #439 slices): offline-direct mode, live Chainalysis/TRM,
provenance.report_hash.Type of Change
skills/skills/skillware/core/loader, env, adaptersskillware/cli.py,docs/usage/cli.mdexamples/*.py, agent loops,examples/README.mdpyproject.toml,MANIFEST.inChecklist (all PRs)
Fixes #…orRefs #…)python -m black --check .,flake8, andruff check .pass locally (or CI-equivalent subset)pytest skills/andpytest tests/pass locally when relevantCHANGELOG.mdupdated under[Unreleased]when user-visible behavior changesexamples/README.mdupdated if this PR adds, renames, or removes a runnable scriptpytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changedpytest tests/test_skill_docs.pywhen catalog Usage Examples or provider snippets changedNew or updated skill
Skip unless this PR adds or changes files under
skills/.Bundle and metadata
skills/<category>/<skill_name>/(fromtemplates/python_skill/or equivalent)manifest.yaml:name(full ID),version,description,parameters,constitution, realissuershort_description,issuer.github,issuer.org,requirements,env_varsEffect, Directive, Assurance
skill.py(Effect; no ad-hoc LLM-generated execution paths)instructions.md(Directive) explains when and how to use the skillcard.json(Presentation) issuer matches manifest when presenttest_skill.py(Assurance) covers execution and schema expectationsSkillLoader.load_skill("<category>/<skill_name>")succeeds (or deps documented)Documentation and catalog
docs/skills/<category>/<skill_name>.md, category hub row, row indocs/skills/README.md, anddocs/sitemap.mdConstitution and safety (skills only)
Read-only screening against bundled public lists plus Etherscan history. No signing, broadcasting, or live Chainalysis/TRM calls. Hosts should halt on
verdict.decisionofDENYand require a person onREVIEW. Not legal advice.Related Issues
Refs #439