Repository navigation
chore(types): Phase 3 of #415, type loader - #460
Merged
rosspeili merged 3 commits intoOct 29, 2026
Merged
Conversation
13 tasks
rosspeili
approved these changes
Oct 29, 2026
rosspeili
left a comment
Contributor
There was a problem hiding this comment.
LGTM @UroojFatima-052, merging as is. <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #415
Phase 3: removes
skillware.core.loaderfrom[[tool.mypy.overrides]]and fixes the 2 errors that surfaced. Typing only, no behavior change.Changes
loader.py(load_skill):manifest: Dict[str, Any] = {}. mypy can't infer the type of an empty dict literal, so it's annotated explicitly.loader.py(to_gemini_tool): the function declaration dict is passed throughtypes.FunctionDeclaration.model_validate(...)before going intotypes.Tool.Tool.function_declarationsis typed as a list ofFunctionDeclaration, and pydantic was already coercing the dict at runtime, so this does the same conversion explicitly. Output is unchanged:test_to_gemini_toolstill seesOBJECT/STRINGtypes.pyproject.toml:loaderdropped from the overrides list.CHANGELOG.md: Unreleased entry.Verification
mypy skillware: Success, no issues in 25 filesblack --check/flake8onloader.py: cleanpytest tests/test_loader.py: 35 passedOnly
skillware.cliremains in the overrides list now (Phase 4).