Conversation
- Area detector in a new file structure - Area detector includes docks - cli points to new area_detector_viewer.py file - Dock Header theme add: roi and stats pv's are hardcoded in pva_reader.py
add: test_cli to test the cli buttons run
…urve toggles in stats plot; drop HKL Viewer/Save buttons from image dock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Major refactor of the area detector viewer. The monolithic
area_det_viewer.pywas split into a package undersrc/dashpva/viewer/area_det/, with each panel extracted into its own dock module (docks/image_dock.py,docks/roi_dock.py,docks/stats_dock.py,docks/mask_dock.py,docks/mouse_pos_dock.py,docks/analysis_dock.py). The CLI entry point now resolves to the new path. Subsequent commits on the branch are layered on top of this restructure:test_clito exercise the CLI button surfaceTest plan
area_det_viewer.pyand the window opens with stats, mouse position, and mask docks initiallypytest tests/unit/test_cli.pypasses -- because we changed the area_det structure it passes