fix(install): make --no-aforge actually skip the aforge download - #926
Merged
Conversation
…forge download The installer only skipped its own explicit `af aforge ensure` step, but `af skill install --all` (which runs first) triggers the same best-effort aforge provisioning hook (skillkit/install.go), so a user who opted out still got the 35 MB binary downloaded into ~/.agentfield/bin. Regressed with #924, which added both the hook and the flag. Export AGENTFIELD_SKIP_AFORGE=1 for the whole run when AFORGE_MODE=none — that env gate is the single switch the Go side honours — so every `af` (and af-tray) invocation the script makes respects the opt-out. Verified against v0.1.130-rc.5 into an isolated HOME: patched installer with --no-aforge installs af + skills + furrow and no aforge; the unpatched script installs aforge despite the flag. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/install.sh --no-aforge(andAFORGE_MODE=none) did not prevent the aforge download. The script only skipped its own explicitaf aforge ensurestep, butaf skill install --all— which runs earlier in the same install — fires the same best-effort provisioning hook (control-plane/internal/skillkit/install.go→aforge.EnsureBestEffort), so opted-out users still got the ~35 MB binary in~/.agentfield/bin. Regressed with #924, which introduced both the hook and the flag.Changes Made
scripts/install.sh: whenAFORGE_MODE=none,export AGENTFIELD_SKIP_AFORGE=1right after arg parsing so everyaf/af-traycall the script makes honours the opt-out (that env var is the one switch the Go side checks). Comment updated on the mode block.install.ps1is unaffected (it does not run the skill install).Verification (live, isolated HOME,
VERSION=v0.1.130-rc.5)--no-tray --no-aforge→ exit 0,af 0.1.130-rc.5+ skill catalog + furrow installed, no~/.agentfield/bin/aforge.origin/mainscript, same flags →~/.agentfield/bin/aforgepresent despite the flag.bash -n scripts/install.shclean.Test Plan
🤖 Generated with Claude Code