Tighten PR 2360 telemetry follow-ups#2407
Open
laxmanclo wants to merge 2 commits into
Open
Conversation
Add PostHog instrumentation for app failures and user CTAs: - daemon_failure (machine-readable code on DaemonStatus, IPC-forwarded) - api_error central interceptor (categorized, IDs stripped) - terminal_attach_failed (pane error + open timeout) - CTA triads: task_create, session_kill, settings_save, orchestrator_spawn (board/restore_dialog), notification open/read All events sanitized: project_id hashed, enum-only codes, raw error messages never sent. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
laxmanclo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2360 with the telemetry review fixes and an upstream
mainmerge so the branch is no longer conflict-blocked.Changes:
project_addsource for project-creation orchestrator spawn telemetryport_unconfirmedas daemon failuresmainconflict changes in project/task settings and API error message handlingValidation
npm --prefix frontend run typechecknpm --prefix frontend run test -- --run src/renderer/lib/api-client.test.ts src/renderer/lib/daemon-telemetry.test.ts src/renderer/lib/telemetry.test.ts src/shared/daemon-attach.test.tsnpx --prefix frontend prettier --check frontend/src/renderer/components/NewTaskDialog.tsx frontend/src/renderer/components/ProjectSettingsForm.tsx frontend/src/renderer/components/NotificationCenter.tsx frontend/src/renderer/lib/api-client.ts frontend/src/renderer/lib/api-client.test.ts frontend/src/renderer/lib/daemon-telemetry.ts frontend/src/renderer/lib/daemon-telemetry.test.ts frontend/src/renderer/lib/telemetry.ts frontend/src/renderer/lib/telemetry.test.ts frontend/src/renderer/routes/_shell.tsxNote: tried pushing directly to
Pritom14:feat/renderer-failure-cta-telemetry, but GitHub rejected the push forlaxmanclowith 403.