[PWGJE] Implemented suggestions from comments on previous pull request.#16002
[PWGJE] Implemented suggestions from comments on previous pull request.#16002Lolle2001 wants to merge 5 commits intoAliceO2Group:masterfrom
Conversation
Lolle2001
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
- Updated the includes according to the O2 guidelines. - Removed registry as an argument in the `analyse` methods.
|
@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914 |
Hi @vkucera, could you reopen this PR please? |
Hi @Lolle2001 , sure, but I think you should see that option too below. |
Hi @vkucera, I am afraid I do not see such an option. Only the buttons |
Please send me a screenshot of the bottom of your PR on GitHub in a private message. |
| /* | ||
| // Experimental Data (analyseDataChargedSubstructure) | ||
| */ | ||
| HNAME(ex_col); // Collision Counter |
There was a problem hiding this comment.
So to me it is a bit unclear if:
a) this is not allowed at all according to the O2Physics guidelines, or it is allowed if the author has a preference.
b) what you would suggest me to do alternatively.
Is a global declaration like const char* mc_eff_det_hfl_mass = "mc_eff_det_hfl_mass" the proper way?
| using JetChargedTableD0 = | ||
| soa::Join<aod::D0ChargedJets, aod::D0ChargedJetConstituents>; |
There was a problem hiding this comment.
Don't break lines unnecessarily.
| #include "PWGHF/Core/DecayChannels.h" | ||
| #include "PWGJE/Core/JetDerivedDataUtilities.h" | ||
| #include "PWGJE/Core/JetHFUtilities.h" | ||
| #include "PWGJE/Core/JetUtilities.h" | ||
| #include "PWGJE/DataModel/Jet.h" | ||
| #include "PWGJE/DataModel/JetReducedData.h" |
There was a problem hiding this comment.
PWGJE headers should be first.
| #include "PWGHF/Core/DecayChannels.h" | |
| #include "PWGJE/Core/JetDerivedDataUtilities.h" | |
| #include "PWGJE/Core/JetHFUtilities.h" | |
| #include "PWGJE/Core/JetUtilities.h" | |
| #include "PWGJE/DataModel/Jet.h" | |
| #include "PWGJE/DataModel/JetReducedData.h" | |
| #include "PWGJE/Core/JetDerivedDataUtilities.h" | |
| #include "PWGJE/Core/JetHFUtilities.h" | |
| #include "PWGJE/Core/JetUtilities.h" | |
| #include "PWGJE/DataModel/Jet.h" | |
| #include "PWGJE/DataModel/JetReducedData.h" | |
| // | |
| #include "PWGHF/Core/DecayChannels.h" |
There was a problem hiding this comment.
This is something the formatting automatically does... but I will change it.
There was a problem hiding this comment.
I know, I configured it. That's why I am telling you how to do it correctly.
|
Don't mark other people's suggestions as resolved, especially if you have not resolved them yet. It is explicitly written in the guidelines. |
Co-authored-by: Copilot <copilot@github.com>
2 participants
analysemethods.