[PWGJE] Refactor collision index handling in diffWakeTreeProducer#16842
Open
wirthni wants to merge 4 commits into
Open
[PWGJE] Refactor collision index handling in diffWakeTreeProducer#16842wirthni wants to merge 4 commits into
wirthni wants to merge 4 commits into
Conversation
Ci is added, because the produced tree is used out of an O2 analysis framework (bare root) and a direct correspondence between collisions and tracks is needed
wirthni
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 12ea35b at 2026-06-30 19:26: Full log here. |
fjonasALICE
requested changes
Jul 1, 2026
| { | ||
| // Event properties | ||
| // DECLARE_SOA_COLUMN(Gi, gi, int64_t); | ||
| DECLARE_SOA_COLUMN(Ci, ci, int64_t); // Collision index - needed because is used as tree |
Collaborator
There was a problem hiding this comment.
I think you should declare here an SOA_INDEX_COLUMN instead (the same as for the tracks) , which will allow you to do the matching also offline. It will simply appear as a int64_t bracnh outside of o2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ci is added, because the produced tree is used out of an O2 analysis framework (bare root) and a direct correspondence between collisions and tracks is needed