Sync deploy with web server config#37
Merged
Merged
Conversation
albs-web-server now sets alembic's sqlalchemy.url at runtime in alws/alembic/env.py from settings.sync_database_url (SYNC_DATABASE_URL), and dropped the hardcoded URL from alws/alembic.ini. That URL was the only per-deployment value the deploy templated, and SYNC_DATABASE_URL is already provided via vars.env, so alembic.ini.j2 is now redundant. Use the upstream alws/alembic.ini directly, matching the existing nginx config approach.
albs-web-server now runs Pulp as a multi-container stack (pulp-minimal + pulp-web) instead of the all-in-one pulp/pulp image. Adjust the deploy to match: - Point the Pulp DB URLs at the separate postgres service (postgres:5432) instead of the old all-in-one pulp host, which is now HTTP-only. - Stop templating Pulp's settings.py: it now ships in the web-server repo at assets/pulp/settings.py and is mounted directly; volumes_root/pulp/ settings is no longer mounted. Drop the template and its directory. - Retarget the admin password reset to the pulp_api container and drop the obsolete 'enable pulp database external access' and pulp stop/start tasks: the postgres:16 service already allows network access (scram-sha-256 via pulp-postgres.env) and stores data under /var/lib/postgresql/data.
The per-service Ansible loop invoked 'docker compose up --build' once per service, serializing image builds. Replace it with a single compose invocation that takes all non-excluded services as arguments, so BuildKit builds in parallel and startup still respects depends_on. - services.yml: filter the service list (minus excluded_containers and pre_bootstrap_excluded_containers) and pass it in one 'up -d --build'. - misc.yml: same for the post-JWT consumer-container recreate and the deferred pre-bootstrap container start. The filtered list is guarded with a length check so an empty argument list can never cause 'docker compose up' to act on ALL services. --compatibility is retained so container names keep the underscore (v1) form the name-based tasks in misc.yml depend on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.