Make fastapi-sqla session factory setup idempotent#1238
Merged
Conversation
Skip re-registering session factories that already exist instead of disposing and recreating their engines on every setup_all() call. Every service runs on a single, long-lived event loop (the dramatiq workers share alws.dramatiq.event_loop, the web app has one loop per process), so the engines stay valid for the process lifetime and disposing/recreating them on every task only churns the asyncpg pool. The test suite runs each module on its own event loop, so reuse a cached factory across modules would raise 'got Future attached to a different loop'. Reset the factories per module in the create_tables fixture so setup_all() rebuilds the engines on the current loop.
anfimovdm
force-pushed
the
idempotent-sqla-setup
branch
from
bdb26dd to
50b8258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip re-registering session factories that already exist instead of disposing and recreating their engines on every setup_all() call. Since setup_all() runs on every dramatiq task invocation, the previous behaviour needlessly tore down and rebuilt connection pools each time.