Skip to content

fix: fix ignoreInvalidConfig#304

Merged
iFurySt merged 1 commit intoAmoyLab:mainfrom
qiankunli:chore/fix-mcp-gateway-yaml
Feb 28, 2026
Merged

fix: fix ignoreInvalidConfig#304
iFurySt merged 1 commit intoAmoyLab:mainfrom
qiankunli:chore/fix-mcp-gateway-yaml

Conversation

@qiankunli
Copy link
Copy Markdown
Contributor

@qiankunli qiankunli commented Feb 28, 2026

Summary by Sourcery

Bug Fixes:

  • Fix parsing of the GATEWAY_STORAGE_API_IGNORE_INVALID_CONFIG environment variable by removing string interpolation so it is handled as a native boolean in the YAML config.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the MCP gateway YAML configuration so that ignoreInvalidConfig is treated as a native boolean value rather than an interpolated string, fixing environment-variable-based configuration for this flag.

Flow diagram for ignoreInvalidConfig configuration handling

flowchart TD
  EnvVar[GATEWAY_STORAGE_API_IGNORE_INVALID_CONFIG env var]
  YAML[Gateway YAML config<br/>ignoreInvalidConfig: $&#123;GATEWAY_STORAGE_API_IGNORE_INVALID_CONFIG:false&#125;]
  Loader[Config loader]
  BoolFlag[ignoreInvalidConfig boolean flag]

  EnvVar --> YAML
  YAML --> Loader
  Loader --> BoolFlag
Loading

File-Level Changes

Change Details Files
Treat ignoreInvalidConfig as a boolean in the storage API configuration instead of a quoted string.
  • Removed quotes around the ignoreInvalidConfig value so the YAML parser reads it as a boolean, while still supporting environment variable substitution with a default of false for GATEWAY_STORAGE_API_IGNORE_INVALID_CONFIG.
configs/mcp-gateway.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@iFurySt iFurySt merged commit bf377db into AmoyLab:main Feb 28, 2026
5 checks passed
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Double-check that removing the quotes around ignoreInvalidConfig matches how the config loader parses booleans elsewhere in this file, and consider aligning the style of other boolean env interpolations for consistency.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Double-check that removing the quotes around `ignoreInvalidConfig` matches how the config loader parses booleans elsewhere in this file, and consider aligning the style of other boolean env interpolations for consistency.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants