Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the MCP gateway YAML configuration so that ignoreInvalidConfig is treated as a native boolean value rather than an interpolated string, fixing environment-variable-based configuration for this flag. Flow diagram for ignoreInvalidConfig configuration handlingflowchart TD
EnvVar[GATEWAY_STORAGE_API_IGNORE_INVALID_CONFIG env var]
YAML[Gateway YAML config<br/>ignoreInvalidConfig: ${GATEWAY_STORAGE_API_IGNORE_INVALID_CONFIG:false}]
Loader[Config loader]
BoolFlag[ignoreInvalidConfig boolean flag]
EnvVar --> YAML
YAML --> Loader
Loader --> BoolFlag
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Double-check that removing the quotes around
ignoreInvalidConfigmatches how the config loader parses booleans elsewhere in this file, and consider aligning the style of other boolean env interpolations for consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that removing the quotes around `ignoreInvalidConfig` matches how the config loader parses booleans elsewhere in this file, and consider aligning the style of other boolean env interpolations for consistency.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: