feat(properties): add properties inside system class #205
Open
dusanparipovic wants to merge 8 commits intodevelopfrom
Open
feat(properties): add properties inside system class #205dusanparipovic wants to merge 8 commits intodevelopfrom
dusanparipovic wants to merge 8 commits intodevelopfrom
Conversation
dusanparipovic
changed the title
dusanparipovic
commented
May 1, 2026
| ConstantData, | ||
| DataBase, | ||
| PortRef, | ||
| PortsConnection, |
dusanparipovic
commented
May 1, 2026
| model=model, | ||
| id=id, | ||
| scenario_group=scenario_group, | ||
| properties=properties or {}, |
Contributor
Author
There was a problem hiding this comment.
{} because of mypy
dusanparipovic
commented
May 1, 2026
| from gems.study.scenario_builder import ScenarioBuilder | ||
|
|
||
|
|
||
| def _resolve_properties_raw_to_dict( |
Contributor
Author
There was a problem hiding this comment.
@tbittar what do you think about this, do we wan't to put this here or to process parsing inside GemsViewBuilder ?
… implement corresponding unit test for YAML parsing
dusanparipovic
commented
May 2, 2026
|
|
||
| class ModelSchema(ModifiedBaseModel): | ||
| id: str | ||
| taxonomy_category: Optional[str] = None # # Optional or mandatory,open question ? |
Collaborator
There was a problem hiding this comment.
@dusanparipovic @tbittar : I suggest optional for now in GemsPy ; yet mandatory in ViewBuilder.
Collaborator
|
@dusanparipovic: shouldn't we move the target branch to develop/ ? |
dusanparipovic
commented
May 6, 2026
… taxonomy_category field
aoustry
requested changes
May 6, 2026
Collaborator
aoustry
left a comment
aoustry
left a comment
There was a problem hiding this comment.
Nice ! Can you also update the doc and the changelog ?
Contributor
Author
Yes no problem, sorry for late response Github doesn't show me comments for some reason... @aoustry |
…my category - Introduced optional `properties` for components in `system.yml`, allowing key/value pairs that are normalized into a dictionary. - Added optional `taxonomy-category` field for models in library YAML files, accessible via `ModelSchema.taxonomy_category`. - Updated documentation to reflect these changes and provided examples in the user guide.
- Updated documentation to replace "key" with "id" in the context of component properties in `system.yml`. - Adjusted test assertions to reflect the change from "key" to "id" for consistency with the updated documentation. - Ensured that error messages for duplicate properties also refer to "id" instead of "key".
dusanparipovic
commented
May 7, 2026
| ### Added | ||
|
|
||
| --- | ||
| - **System components: `properties`** - introduces optional `properties` on components in `system.yml` (a list of `id`/`value` pairs). These are normalized into a `dict[str, str]` on the resolved `Component` (duplicate ids raise a `ValueError`). |
Contributor
Author
There was a problem hiding this comment.
Second sentence is directly connected to this.
Do we really want to put this parsing here or that parsing will be done inside GVB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.