chore: Update supported languages list#162
Conversation
|
The PR title and description do not comply with the project's Git Commit Guidelines: missing [LLM] prefix, mandatory What/Why sections, agent name, and issue references. |
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The data update is a straightforward refresh of Wikipedia language statistics that accurately reflects the latest data without impacting logic or architecture. While there are minor metadata and localization issues, the core changes are sound and approved.
87d57cb to
ef417bc
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR violates mandatory metadata formatting guidelines for AI Agents (missing [LLM] prefix and agent name) and contains hardcoded English strings that violate the project's localization policy.
ef417bc to
cfe7131
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR fails to follow mandatory naming and description guidelines for AI Agents and violates localization policies by hardcoding language names in English in an auto-generated file.
cfe7131 to
1e368a9
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR violates AI-generated contribution guidelines regarding title and description formatting and introduces localization technical debt by hardcoding language names in English in a generated file.
Detailed Inline Feedback (Fallback)
- app/src/main/java/com/anysoftkeyboard/janus/app/util/SupportedLanguages.kt (15-2782): The 'name' field for each SupportedLanguage is hardcoded in English, violating the project's localization policy. These should be resolved dynamically (e.g., using Locale(code).getDisplayName()) or managed via string resources. Since this file is generated, the fix should be implemented in scripts/update_languages.py to prevent recurring technical debt.
- scripts/update_languages.py (113): The comment states that the languages are sorted 'alphabetical by code', but the implementation on line 128 actually sorts by 'name'. The comment should be updated to reflect the actual sorting logic.
649ef9c to
2b20988
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The review was rejected due to non-compliance with established Git Commit Guidelines for AI agents, specifically regarding PR metadata (missing prefix, description sections, agent name, and issue reference).
2b20988 to
9cdd055
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR violates metadata guidelines (missing [LLM] prefix and required sections), hardcodes localization strings instead of using resource files, and contains suspicious data statistics for Urdu and other languages.
9cdd055 to
7e5b4ee
Compare
anysoftkeyboard-bot
left a comment
anysoftkeyboard-bot
left a comment
There was a problem hiding this comment.
The PR contains significant data anomalies regarding language statistics and violates project standards for metadata and localization.
| activeUserCount = 35, | ||
| articleCount = 4735, | ||
| pageCount = 8815, | ||
| activeUserCount = 24, | ||
| ), | ||
| SupportedLanguage( |
There was a problem hiding this comment.
Critical Risk: The articleCount for Urdu shows a massive jump from 450,214 to 652,856 (~45% increase) while the activeUserCount decreased. This suggests either a massive automated bot-import or an error in source statistics.
| activeUserCount = 20, | ||
| articleCount = 7873, | ||
| pageCount = 31961, | ||
| activeUserCount = 16, | ||
| ), | ||
| SupportedLanguage( |
There was a problem hiding this comment.
Critical Risk: The articleCount for Cheyenne dropped from 1,599 to 718 (>50% decrease), indicating a need for a sanity check on data ingestion to ensure data stability.
| SupportedLanguage( | ||
| code = "isv", | ||
| name = "Interslavic", | ||
| localName = "medžuslovjansky", |
There was a problem hiding this comment.
Critical Risk & Technical Debt: Interslavic is being added with zero active users, which is potentially unreliable. Additionally, its name and localName are hardcoded literals instead of using resource-based localization from strings.xml.
| localName = "मगही", | ||
| articleCount = 3654, | ||
| pageCount = 16616, | ||
| activeUserCount = 0, |
There was a problem hiding this comment.
Critical Risk & Technical Debt: Magahi is being added with zero active users, which is potentially unreliable. Additionally, its name and localName are hardcoded literals instead of using resource-based localization from strings.xml.
| articleCount = 25097, | ||
| pageCount = 63422, | ||
| activeUserCount = 23, | ||
| articleCount = 25096, |
There was a problem hiding this comment.
Observation: The articleCount for Bishnupriya decreased by 1, a minor non-monotonic change likely due to a single page deletion.
2 participants
This PR updates the list of supported Wikipedia languages based on the latest statistics.