Skip to content

+fix: resolve search box losing focus during find and replace (#8802)#8805

Open
harrish243 wants to merge 1 commit into
AppFlowy-IO:mainfrom
harrish243:fix-8802
Open

+fix: resolve search box losing focus during find and replace (#8802)#8805
harrish243 wants to merge 1 commit into
AppFlowy-IO:mainfrom
harrish243:fix-8802

Conversation

@harrish243

@harrish243 harrish243 commented Jun 12, 2026

Copy link
Copy Markdown

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Bug Fixes:

  • Work around the editor refocusing behavior so the search text field regains focus after executing a find-and-highlight action.

@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a focus-restoration workaround so the find-and-replace search text field regains focus after the editor steals it when updating selection.

Sequence diagram for restoring search box focus during find and replace

sequenceDiagram
  actor User
  participant FindMenu
  participant SearchService
  participant Editor
  participant FocusNode

  User->>FindMenu: _searchPattern()
  FindMenu->>SearchService: findAndHighlight(textController.text)
  SearchService->>Editor: updateSelection
  Editor->>Editor: requestFocus()
  FindMenu->>FindMenu: Future.delayed(Duration(milliseconds: 50))
  FindMenu->>FocusNode: requestFocus()
Loading

File-Level Changes

Change Details Files
Ensure the find-and-replace search field regains focus after search triggers editor selection updates.
  • Call searchService.findAndHighlight and then schedule a delayed callback to re-request focus on the search field
  • Use Future.delayed with a short duration to wait for the editor focus request to complete before restoring focus to the search field
  • Guard the delayed callback with a mounted check before requesting focus via the provided focus node
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/find_and_replace/find_and_replace_menu.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of using a hard-coded Future.delayed(const Duration(milliseconds: 50)), consider using WidgetsBinding.instance.addPostFrameCallback so the focus re-request happens exactly after the frame that updates the selection, avoiding arbitrary timing assumptions.
  • Since _searchPattern may be called repeatedly, you might want to guard against overlapping delayed callbacks (e.g., by cancelling or debouncing) to avoid multiple focus requests racing with each other.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of using a hard-coded `Future.delayed(const Duration(milliseconds: 50))`, consider using `WidgetsBinding.instance.addPostFrameCallback` so the focus re-request happens exactly after the frame that updates the selection, avoiding arbitrary timing assumptions.
- Since `_searchPattern` may be called repeatedly, you might want to guard against overlapping delayed callbacks (e.g., by cancelling or debouncing) to avoid multiple focus requests racing with each other.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants