+fix: resolve search box losing focus during find and replace (#8802)#8805
Open
harrish243 wants to merge 1 commit into
Open
+fix: resolve search box losing focus during find and replace (#8802)#8805harrish243 wants to merge 1 commit into
harrish243 wants to merge 1 commit into
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a focus-restoration workaround so the find-and-replace search text field regains focus after the editor steals it when updating selection. Sequence diagram for restoring search box focus during find and replacesequenceDiagram
actor User
participant FindMenu
participant SearchService
participant Editor
participant FocusNode
User->>FindMenu: _searchPattern()
FindMenu->>SearchService: findAndHighlight(textController.text)
SearchService->>Editor: updateSelection
Editor->>Editor: requestFocus()
FindMenu->>FindMenu: Future.delayed(Duration(milliseconds: 50))
FindMenu->>FocusNode: requestFocus()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Instead of using a hard-coded
Future.delayed(const Duration(milliseconds: 50)), consider usingWidgetsBinding.instance.addPostFrameCallbackso the focus re-request happens exactly after the frame that updates the selection, avoiding arbitrary timing assumptions. - Since
_searchPatternmay be called repeatedly, you might want to guard against overlapping delayed callbacks (e.g., by cancelling or debouncing) to avoid multiple focus requests racing with each other.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of using a hard-coded `Future.delayed(const Duration(milliseconds: 50))`, consider using `WidgetsBinding.instance.addPostFrameCallback` so the focus re-request happens exactly after the frame that updates the selection, avoiding arbitrary timing assumptions.
- Since `_searchPattern` may be called repeatedly, you might want to guard against overlapping delayed callbacks (e.g., by cancelling or debouncing) to avoid multiple focus requests racing with each other.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Bug Fixes: