feat(i18n): add missing Japanese (ja) translations for the sign-in flow#8833
Open
greymoth-jp wants to merge 1 commit into
Open
feat(i18n): add missing Japanese (ja) translations for the sign-in flow#8833greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds the 40 missing Japanese File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Identical pattern | 1 | warning | contribute (via Fink 🐦) |
Author
|
On the Ninja i18n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Japanese locale (
frontend/resources/translations/ja-JP.json) is behinden-US(2776 vs 2410 keys). In particular thesignInsection had 40 missing keys, so the sign-in, password-reset, and verification-code screens fell back to English for Japanese users.Change
Adds the 40 missing
signIn.*keys, completing the full authentication surface (sign-in, password reset, login-code / verification, local mode). Follows the existing Japanese house style — noun-form button labels (パスワードをリセット), 〜してください for instructions, product names kept in English (AppFlowy Cloud, Magic Link, Google, GitHub), and\npreserved verbatim. Key order mirrorsen-US.json; existing translations are untouched.Testing
ja-JP.jsonvalidated as valid JSON; change is scoped to one file (40 insertions / 0 deletions), LF line endings.The other missing sections (ai / document / settings, ~300+ keys) are intentionally left for follow-up PRs to keep this review small.
Summary by Sourcery
New Features: