Skip to content

feat(i18n): add missing Japanese (ja) translations for the sign-in flow#8833

Open
greymoth-jp wants to merge 1 commit into
AppFlowy-IO:mainfrom
greymoth-jp:feat/ja-i18n
Open

feat(i18n): add missing Japanese (ja) translations for the sign-in flow#8833
greymoth-jp wants to merge 1 commit into
AppFlowy-IO:mainfrom
greymoth-jp:feat/ja-i18n

Conversation

@greymoth-jp

@greymoth-jp greymoth-jp commented Jun 24, 2026

Copy link
Copy Markdown

Problem

The Japanese locale (frontend/resources/translations/ja-JP.json) is behind en-US (2776 vs 2410 keys). In particular the signIn section had 40 missing keys, so the sign-in, password-reset, and verification-code screens fell back to English for Japanese users.

Change

Adds the 40 missing signIn.* keys, completing the full authentication surface (sign-in, password reset, login-code / verification, local mode). Follows the existing Japanese house style — noun-form button labels (パスワードをリセット), 〜してください for instructions, product names kept in English (AppFlowy Cloud, Magic Link, Google, GitHub), and \n preserved verbatim. Key order mirrors en-US.json; existing translations are untouched.

Testing

  • ja-JP.json validated as valid JSON; change is scoped to one file (40 insertions / 0 deletions), LF line endings.

The other missing sections (ai / document / settings, ~300+ keys) are intentionally left for follow-up PRs to keep this review small.

Summary by Sourcery

New Features:

  • Add Japanese translations for all missing sign-in, password reset, and verification code screen strings in the ja-JP locale.

@CLAassistant

CLAassistant commented Jun 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sourcery-ai

sourcery-ai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the 40 missing Japanese signIn.* translations in ja-JP.json so the full sign-in and authentication flow no longer falls back to English, keeping key order aligned with en-US and following the existing Japanese copy style.

File-Level Changes

Change Details Files
Complete Japanese translations for the sign-in and authentication flow to eliminate English fallbacks.
  • Added all 40 missing signIn.* keys for Japanese, covering sign-in, password reset, verification/login code, and local mode flows
  • Matched key ordering to the en-US locale file while leaving existing Japanese translations unchanged
  • Followed existing Japanese localization conventions for tone, button-label style, product name handling, and newline preservation
  • Verified the updated ja-JP translations file is valid JSON with consistent line endings
frontend/resources/translations/ja-JP.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Identical pattern 1 warning contribute (via Fink 🐦)

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@greymoth-jp

Copy link
Copy Markdown
Author

On the Ninja i18n identicalPattern warning for signIn.switchToAppFlowyCloud: that value is the product name "AppFlowy Cloud", so the Japanese string is intentionally identical to English — JP localization keeps brand names in Latin script rather than transliterating them. The other 39 keys are fully translated. Happy to suppress it in the lint config instead if you prefer a clean check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants