Review 10 — Admin UI in English: template designer + content library (translation complete) - #34
Draft
ArneeMe wants to merge 1 commit into
Draft
Conversation
The last two Norwegian-only surfaces now render from strings.ts via useAdminLang, completing the admin translation: - edit_pdf: editor page, DesignerComponent (toolbar, dialogs, toasts), BindingsEditor (source/system labels, all field configs and helper texts), SchemaEditor (field types, lookup-list preview), StarterTemplatePicker. - rediger: content library shell, all four panels and rows (signatures, logos, text blocks, lookup lists), usage badges, delete confirmations, ImageUpload messages. Deliberately untouched: database-persisted values (asset names, template content, starter template data) — only UI chrome. Module-level label constants became value lists with labels looked up from the dictionary, so both languages stay compile-enforced in sync. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
Deploying inf319-certificate with
|
| Latest commit: |
23d322f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffaff82a.inf319-certificate.pages.dev |
| Branch Preview URL: | https://claude-review-10-designer-en.inf319-certificate.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #33 (part 10 of the review stack). Pure language refactor — easy approve. This completes the English translation of the entire application.
The last two Norwegian-only surfaces now render from
strings.tsvia the persisteduseAdminLangtoggle:edit_pdf/): editor page, DesignerComponent (toolbar buttons, save/preview dialogs, toasts), BindingsEditor (all seven source-kind labels, four system slots, every field config and helper text), SchemaEditor (field-type labels, lookup-list preview), StarterTemplatePicker.rediger/): shell + tabs, all four panels and their rows (signatures, logos, text blocks, lookup lists), usage badges, delete confirmations with Norwegian definite-form grammar handled per kind, ImageUpload's error messages.Deliberately untouched: anything persisted to the database (asset names, template content, starter-template data) — only UI chrome is localized. Module-level label constants became value lists with labels looked up from the typed dictionary, so NO/EN parity remains a compile error to break. ~110 new keys per language.
Verification: typecheck, lint, 110 unit tests, 8/8 E2E, production build — all green. (One E2E flake observed from dev-server first-compile latency; passes consistently in isolation, and CI retries cover it.)
🤖 Generated with Claude Code
https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
Generated by Claude Code