Skip to content

Fix missing padding in the poll editor - #167

Open
benitoalba wants to merge 1 commit into
Automattic:trunkfrom
benitoalba:fix/119-poll-editor-padding
Open

Fix missing padding in the poll editor#167
benitoalba wants to merge 1 commit into
Automattic:trunkfrom
benitoalba:fix/119-poll-editor-padding

Conversation

@benitoalba

@benitoalba benitoalba commented Jul 13, 2026

Copy link
Copy Markdown

Fixes #119

Changes proposed in this Pull Request

The legacy poll editor inherited the full-bleed margins used by the Crowdsignal dashboard, causing the form to touch both edges of wp-admin. The Save panel also used a class instead of the standard minor-publishing ID, so its controls had no inner spacing.

This change:

  • applies normal wp-admin gutters only to create and edit poll screens
  • restores 10px padding to the Save panel
  • leaves the full-bleed layout unchanged for other Crowdsignal pages

Testing instructions

  1. Connect a Crowdsignal account and open Crowdsignal > Polls.
  2. Create or edit a poll.
  3. Confirm the editor has normal left and right gutters.
  4. Confirm the Save options have inner padding.
  5. Confirm non-editor Crowdsignal screens retain their existing full-bleed layout.

Validated locally on WordPress 7.0.1:

  • PHP syntax checks pass for both changed PHP files.
  • Unit suite passes (2 tests, 2 assertions).
  • git diff --check passes.
  • Edit, create, preview, and narrow viewport layouts were visually checked.
  • The integration suite could not start because offline wp-env did not populate /wordpress-phpunit; bootstrap failed before tests ran.
  • Repository-wide PHPCS reports existing legacy violations; a filtered report found no violations on the new lines.

Screenshot or video

Before: image

After: image

Proposed changelog entry for your changes

Fix missing padding in the Crowdsignal poll editor.

Release Notes

  • Fix missing padding in the Crowdsignal poll editor.

@benitoalba
benitoalba marked this pull request as ready for review July 18, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit admin page missing padding

1 participant