SQLite: cap trigger recursion for WebAssembly stacks#781
Conversation
Phase B-1 matrix build status —
|
| Package | Arch | Status | Sha |
|---|---|---|---|
| sqlite | wasm32 | built | 5a13e73a |
| sqlite | wasm64 | built | d7ce2dd3 |
| php | wasm32 | built | 9fd390fa |
| lamp | wasm32 | built | ca2226cc |
| wordpress | wasm32 | built | 0eb6e1e7 |
Auto-generated; replaced on each push. Raw data in the publish-status workflow artifact.
Member
Author
3828f36 to
4b04ff3
Compare
152c9a2 to
9e3fd3f
Compare
This was referenced Jul 13, 2026
Member
Author
|
Closing this focused source PR because its unique SQLite trigger-recursion limit work is now carried by #934 at exact green head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
#907 already landed the platform memory-management and syscall-path fixes that the old composite SQLite stack depended on. This PR does not copy those runtime changes.
The remaining change is deliberately small:
sqllimits1.testSQL-length filler comment-only so that test reaches the SQL-length limit instead of the lower expression-depth limit;This PR is stacked on focused #780, which owns the compound-select, expression-depth, and JSON-depth limits. Its unique diff is one commit and five files.
Deliberately removed
I removed the old #769 ancestry, mmap/runtime work, broad harness changes, the
no_mutexpatches, and the 2 GiB maximum-memory override. Those changes do not belong in this package-focused slice.ABI and package artifacts
There is no Kandelo ABI change. The SQLite compile flags change output bytes, so
packages/registry/sqlite/build.tomlmoves from revision 3 to revision 4. No other package revisions change.Validation
Run through
scripts/dev-shell.sh:bash scripts/check-abi-version.sh;e_fkey(941 tests),triggerC(120 tests), andsqllimits1(3,117 tests);All focused runs passed. CI is running on the rewritten head.
Not run locally: the full Vitest suite, the full non-slow browser suite, libc/POSIX/Sortix conformance, the complete upstream SQLite suite, or
./run.sh browser. Performance was not measured, and this PR makes no performance claim.