Skip to content

feat: implement OffscreenCanvas.convertToBlob#2127

Open
jimmywarting wants to merge 1 commit into
Automattic:masterfrom
jimmywarting:feature/convertToBlob
Open

feat: implement OffscreenCanvas.convertToBlob#2127
jimmywarting wants to merge 1 commit into
Automattic:masterfrom
jimmywarting:feature/convertToBlob

Conversation

@jimmywarting

@jimmywarting jimmywarting commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Have you updated CHANGELOG.md?

This new feature would require ppl to use NodeJS v18 but it's not required.
ppl could also polyfill Blob themself it they wanted to use it.

closes #1845

LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
Comment thread lib/canvas.js
LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
Comment thread lib/canvas.js Outdated
LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
Comment thread lib/canvas.js Outdated
LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes

@LinusU LinusU left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Left som small comments to address

Could you add a line in the changelog file as well?

@jimmywarting

jimmywarting commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

bump

@LinusU

LinusU commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

Sorry for the delay on this, could you add a line to the changelog please? 🙏

@jimmywarting

jimmywarting commented Jul 24, 2023

Copy link
Copy Markdown
Contributor Author

done

LinusU
LinusU approved these changes Jul 24, 2023
View reviewed changes

@LinusU LinusU left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@LinusU LinusU force-pushed the feature/convertToBlob branch from ef2f181 to 329ee9a Compare July 24, 2023 12:22
@LinusU

LinusU commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

(Windows tests are failing, testing rebasing on lastest master)

@jimmywarting

jimmywarting commented Aug 27, 2023

Copy link
Copy Markdown
Contributor Author

The failed test is unrelated to this PR. maybe this can be merged anyway?

  1) Canvas
       registerFont:
     Error: ENOENT: no such file or directory, lstat 'D:\a\node-canvas\node-canvas\examples\pfennigFont\pfennigMultiByte🚀.ttf'

@zbjornson zbjornson force-pushed the master branch 2 times, most recently from 64ed3d8 to ff0f2ab Compare December 28, 2023 23:22
@Kuboczoch Kuboczoch mentioned this pull request Aug 27, 2024
Open
@ShaMan123 ShaMan123 mentioned this pull request Oct 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinusU LinusU LinusU approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce blob's

2 participants

@jimmywarting @LinusU