Skip to content

Conversation

@just-mitch
Copy link
Collaborator

@just-mitch just-mitch commented Oct 4, 2025

Add GitHub Actions for Network Scenario Tests on PRs

This PR adds a new workflow that allows developers to trigger network scenario tests on pull requests by adding the ci-network-scenario label. The workflow deploys a full Aztec network in a PR-specific Kubernetes namespace and runs scenario tests against it.

Key features:

  • New GitHub workflow ci3-network-scenario.yml triggered by the ci-network-scenario label
  • Reusable GitHub Actions for GCP authentication and network environment setup
  • Automatic cleanup of Kubernetes resources after tests complete
  • PR comments with test results and status information
  • Caching to prevent redundant test runs for the same code

The implementation extracts common functionality from the existing test-network-scenarios.yml workflow into reusable GitHub Actions:

  • setup-gcp-auth - Handles GCP service account authentication and kubectl setup
  • setup-network-env - Creates network environment configuration and SSH keys

This allows developers to run the same network scenario tests that are run on releases, but on their PRs before merging.

Copy link
Collaborator Author

just-mitch commented Oct 4, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@just-mitch just-mitch marked this pull request as ready for review October 4, 2025 09:37
@just-mitch just-mitch requested a review from charlielye as a code owner October 4, 2025 09:38
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 99620f8 to b84378a Compare October 4, 2025 10:39
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

✅ Network Scenario Tests PASSED

Test Status: passed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from b84378a to 430d20e Compare October 4, 2025 11:00
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 430d20e to 37056c7 Compare October 4, 2025 14:33
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 37056c7 to 8cd6ff8 Compare October 7, 2025 07:24
@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 8cd6ff8 to 4886832 Compare October 16, 2025 12:11
@just-mitch just-mitch removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 16, 2025
@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 4886832 to 704a0e6 Compare October 16, 2025 16:17
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 16, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 16, 2025
@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 704a0e6 to 78cf923 Compare October 16, 2025 21:35
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 16, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 16, 2025
@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 78cf923 to 78794a5 Compare October 17, 2025 18:44
SALT=1757186002
NAMESPACE=${{ inputs.namespace }}
AZTEC_DOCKER_IMAGE="${{ inputs.docker-image }}"
AZTEC_EPOCH_DURATION=8
Copy link
Collaborator

@PhilWindle PhilWindle Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this network perpetually re-org? 8 slots isn't enough time to prove the epoch. The nightly runs are set to 32.

@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 6e7b6f7 to f7b526b Compare October 25, 2025 18:49
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 25, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 25, 2025
@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from f7b526b to 1b97f02 Compare October 25, 2025 19:31
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 25, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 25, 2025
@github-actions
Copy link
Contributor

✅ Network Scenario Tests PASSED

Test Status: passed
Namespace: pr-17505-scenario
Cleanup Status: ✅ Cleaned up successfully
Workflow Run: View logs


To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 1b97f02 to ad58f0a Compare October 25, 2025 21:23
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 25, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 25, 2025
@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ⚠️ Cleanup may have failed
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.

Manual Cleanup Required

If cleanup failed, you may need to manually delete the namespace:

kubectl delete namespace pr-17505-scenario

To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from ad58f0a to 318defc Compare October 26, 2025 14:40
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 26, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 26, 2025
@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ⚠️ Cleanup may have failed
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.

Manual Cleanup Required

If cleanup failed, you may need to manually delete the namespace:

kubectl delete namespace pr-17505-scenario

To re-run tests, add the ci-network-scenario label again


on:
pull_request:
types: [labeled]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm of the camp that ci3.yml could handle everything here. We have already have a mix of machines running with diff CI settings on them for the merge queue path

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 318defc to 67cffac Compare October 26, 2025 18:23
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 26, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 26, 2025
@github-actions
Copy link
Contributor

❌ Network Scenario Tests FAILED

Test Status: failed
Namespace: pr-17505-scenario
Cleanup Status: ⚠️ Cleanup may have failed
Workflow Run: View logs

⚠️ Tests Failed

Please check the workflow logs for details.

Manual Cleanup Required

If cleanup failed, you may need to manually delete the namespace:

kubectl delete namespace pr-17505-scenario

To re-run tests, add the ci-network-scenario label again

@just-mitch just-mitch force-pushed the mitch/a-66-github-label-for-running-scenario-tests branch from 67cffac to 7bb68d7 Compare October 26, 2025 19:56
@just-mitch just-mitch added the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 26, 2025
@AztecBot AztecBot removed the ci-network-scenario Run network scenario tests using an image built from this PR label Oct 26, 2025
@github-actions
Copy link
Contributor

✅ Network Scenario Tests PASSED

Test Status: passed
Namespace: pr-17505-scenario
Cleanup Status: ⚠️ Cleanup may have failed
Workflow Run: View logs

Manual Cleanup Required

If cleanup failed, you may need to manually delete the namespace:

kubectl delete namespace pr-17505-scenario

To re-run tests, add the ci-network-scenario label again

@just-mitch
Copy link
Collaborator Author

Closing because @ludamad did this better elsewhere 👍

@just-mitch just-mitch closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants