feat: add SMB scenarios 10 and 11, load scenarios from JSON config#532
Merged
jaredfholgate merged 2 commits intomainfrom Apr 10, 2026
Merged
feat: add SMB scenarios 10 and 11, load scenarios from JSON config#532jaredfholgate merged 2 commits intomainfrom
jaredfholgate merged 2 commits intomainfrom
Conversation
- Add path property to TerraformScenarios.json for all scenarios - Add scenario 10 (SMB Single-Region Hub and Spoke VNet) - Add scenario 11 (SMB Single-Region Virtual WAN) - Replace hardcoded scenario hashtable with dynamic JSON loading - Fix int64/int32 type mismatch when looking up scenario paths
github-project-automation
Bot
moved this to To triage
in Azure Landing Zone Issues & PRs Triage
jtracey93
approved these changes
Apr 10, 2026
github-project-automation
Bot
moved this from To triage
to Done
in Azure Landing Zone Issues & PRs Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing SMB scenarios 10 and 11 to the accelerator folder structure creation, and refactors scenario management to use the existing
TerraformScenarios.jsonconfig file as the single source of truth.Closes Azure/Azure-Landing-Zones#4105
Changes
TerraformScenarios.json
pathproperty to each scenario entry, mapping scenario numbers to their tfvars file pathssmb-single-region/hub-and-spoke-vnet.tfvarssmb-single-region/virtual-wan.tfvarsNew-AcceleratorFolderStructure.ps1
TerraformScenarios.jsonint64/int32type mismatch when looking up scenario paths (JSON parser returnsint64, parameter is[int]/int32— without the cast, hashtable lookup returns `` andCopy-Itemcreates a directory instead of copying the file)