Skip to content

fix(vscode): Prompt for azure connector details and start design-time host on new projects#8607

Open
andrew-eldridge wants to merge 4 commits into
Azure:mainfrom
andrew-eldridge:aeldridge/newProjectDesignTimeFix
Open

fix(vscode): Prompt for azure connector details and start design-time host on new projects#8607
andrew-eldridge wants to merge 4 commits into
Azure:mainfrom
andrew-eldridge:aeldridge/newProjectDesignTimeFix

Conversation

@andrew-eldridge
Copy link
Copy Markdown
Contributor

@andrew-eldridge andrew-eldridge commented Nov 21, 2025

Fixes #6824

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adds the following initialization steps at end of 'Create new project' flow:

  • Prompts for azure connector details
  • Starts design-time host for the new project

Impact of Change

  • Users: Fixes incongruency between 'Create new workspace' and 'Create new project' where the latter doesn't immediately get azure connector details or start design-time
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added the VSCode Issues or PRs specific to VS Code extension label Nov 21, 2025
Copilot AI review requested due to automatic review settings November 21, 2025 19:38
@andrew-eldridge andrew-eldridge added risk:low Low risk change with minimal impact bug Something isn't working labels Nov 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 21, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: None — the title is clear, follows conventional commit style with scope, and succinctly describes the change.
  • Recommendation: Keep as-is. (Optional: capitalize Azure -> Prompt for Azure connector details... if you want consistent capitalization.)

Commit Type

  • Properly selected (fix).
  • Note: Only one type is selected which is correct.

Risk Level

  • Assessment: The PR has a risk:low label and the PR body selects Low. The code diff is small (34 additions, 0 deletions across 3 files) and the changes appear limited in scope, so Low is appropriate.

What & Why

  • Current: "Adds the following initialization steps at end of 'Create new project' flow:\n- Prompts for azure connector details\n- Starts design-time host for the new project"
  • Issue: The section is present and concise. No major issue.
  • Recommendation: (No change required) You may optionally expand one sentence to indicate whether the calls are synchronous or intentionally fire-and-forget, e.g. "These steps are invoked after project creation; they are started without blocking the UI so project creation completes promptly." if accurate.

Impact of Change

  • The Impact section is present and acceptable.
  • Recommendation: Expand slightly to call out expected user-facing behavior: e.g. that new projects will now prompt immediately for connector details and will start a local design-time host so that features relying on it work out of the box.
    • Users: New projects will now receive a prompt for connector details and will start a design-time host automatically.
    • Developers: No API changes; minor init behavior change for project creation flow.
    • System: No large performance or architecture changes anticipated.

Test Plan

  • Assessment: The PR body currently marks only "Manual testing completed" and leaves "Unit tests" and "E2E tests" unchecked. The code diff, however, includes unit test updates to CreateLogicAppProject.test.ts (new test cases and mocks). This is an inconsistency that must be corrected.
  • Recommendation: Update the Test Plan in the PR body to reflect reality:
    • If the unit tests were updated: check Unit tests added/updated and briefly list which tests were updated (e.g. apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/__test__/CreateLogicAppProject.test.ts).
    • If you also ran manual testing, keep that checked and add a short note describing what manual scenarios you exercised (create new project in a workspace, create new project outside a workspace, etc.).
    • If E2E tests were not updated, leave that unchecked but provide a short rationale for why not.

Additionally, because new behavior modifies initialization (starts design-time host and prompts for connectors), describe what environment this was manually tested in (OS, VS Code version, any prerequisites) so reviewers can reproduce if needed.

⚠️ Contributors

  • Assessment: Contributors are listed (@andrew-eldridge). Good.
  • Recommendation: If others helped (PMs/designers/reviewers), consider adding them here for attribution. Not required.

⚠️ Screenshots/Videos

  • Assessment: Not included. This is acceptable for a background/behavioral change; screenshots are optional.
  • Recommendation: If you changed any UI flows (wizard dialogs), a screenshot showing the new prompt would be helpful but not required.

Summary Table

Section Status Recommendation
Title Keep as-is (optional: capitalize Azure)
Commit Type No change needed
Risk Level Matches label and code diff
What & Why Optionally clarify sync vs fire-and-forget
Impact of Change Expand with short user/dev/system bullet points
Test Plan Update to mark Unit tests added/updated and add manual test details
Contributors ⚠️ Optionally add other contributors
Screenshots/Videos ⚠️ Optional screenshot of new prompt if UI changed

Final Message
Please update the PR body to fix the Test Plan inconsistency: check "Unit tests added/updated" and mention the updated test file (apps/vs-code-designer/.../CreateLogicAppProject.test.ts). Add a short note on manual testing environment and scenarios. Optionally clarify whether the newly-invoked functions are awaited or intentionally fire-and-forget (this helps reviewers reason about potential timing issues). Once you update the Test Plan and add those brief clarifications, remove the needs-pr-update label if you have it, and request a re-review. Thank you for the clear title and concise description — the PR is almost ready!


Last updated: Wed, 29 Apr 2026 18:31:17 GMT

@github-actions
Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: Title is specific, includes area affected, nature of fix, and scope
  • Recommendation: None needed. This is an ideal PR title.

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Risk level "Low" is selected. PR is labeled "Risk:Low", and based on the code change (small, targeted, 7 additions, no deletions, scope limited to initialization after project creation), this is appropriate.

What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow:
  • Prompts for azure connector details
  • Starts design-time host for the new project
  • Issue: Clear, brief, describes what was changed and why (adds missing initialization step).
  • Recommendation: None needed.

Impact of Change

  • Clear indication of impact to users (addressing missing initialization after project creation), developers (N/A), and system (N/A).
  • Recommendation: Users: Clear
    • Developers: N/A, but could explicitly state if there are any expected developer-facing changes or workflow impact (optional)
    • System: N/A, but if system behavior changes (dependencies, broader impact), mention (optional)

Test Plan

  • "Manual testing completed" is checked, which is common for small workflow fixes. No unit/E2E test required for a simple UX fix.

Contributors

  • @andrew-eldridge listed
  • Minimal, but if more contributors (PM, Design) helped, tagging them is appreciated (optional)

Screenshots/Videos

  • Not needed for backend/initialization workflow change. Section left blank, this passes.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors Optional: Tag PMs/designers if they contributed
Screenshots/Videos None

The PR passes all body and title checks, and the risk level is correct. No changes required. Thank you for maintaining clear, concise documentation in your PR!


Last updated: Fri, 21 Nov 2025 19:38:41 GMT

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an inconsistency between the "Create new workspace" and "Create new project" flows by adding Azure connector details prompting and design-time host initialization to the project creation process. Previously, these initialization steps were only performed for workspace creation, leaving newly created projects without immediate Azure connector configuration or a running design-time API.

Key changes:

  • Added calls to getAzureConnectorDetailsForLocalProject() and startDesignTimeApi() at the end of the createLogicAppProject() function
  • Added a blank line formatting improvement in azureConnectorWizard.ts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/vs-code-designer/src/app/commands/workflows/azureConnectorWizard.ts Minor formatting change - added blank line after function definition
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts Added Azure connector details prompting and design-time API initialization calls after project creation, with necessary imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working needs-pr-update risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Options like "host.json" and "local.settings.json" under workflow_designtime are not appearing as expected.

4 participants