fix(azure.ai.agents): skip scale config for vnext hosted agents#7341
Open
fix(azure.ai.agents): skip scale config for vnext hosted agents#7341
Conversation
When enableHostedAgentVNext=true, the platform manages container lifecycle and scaling. Don't write the scale block to azure.yaml during agent init since it's unused by the vnext backend. Fixes #7267 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
requested review from
hemarina,
vhvb1989,
wbreza and
weikanglim
as code owners
spboyer
requested review from
JeffreyCA,
rajeshkamal5050,
tg-msft,
therealjohn,
trangevi and
trrwilson
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure AI Agents extension to avoid writing container.scale defaults into azure.yaml when hosted agent vnext is enabled (enableHostedAgentVNext=true), while still preserving any existing scale settings already present in the project config.
Changes:
- Conditionally omit creating
container.scaledefaults during init flows when vnext is enabled. - During deploy hooks, preserve an existing
container.scaleblock but avoid generating a new default one for vnext-enabled environments. - Guard defaulting logic to handle
Scale == nilsafely.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cli/azd/extensions/azure.ai.agents/internal/cmd/listen.go | Preserves existing scale settings but skips creating new defaults for vnext; adds nil-guards around defaulting. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/init_from_code.go | Omits default scale generation during init-from-code when vnext is enabled. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/init.go | Omits default scale generation during interactive init when vnext is enabled. |
Accept optional AzdClient parameter in isVNextEnabled to avoid creating a new gRPC connection on each call. Pass the existing client from populateContainerSettings (listen.go) and InitAction (init.go) where one is already available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7267
When
enableHostedAgentVNext=true, the platform manages container lifecycle and scaling. Thescaleblock inazure.yamlis unused by the vnext backend and should not be written during agent init.Changes
init.go—populateContainerSettings()conditionally adds Scale only when vnext is not enabledinit_from_code.go—addToProject()conditionally adds Scale the same waylisten.go— Preserves existing Scale settings from azure.yaml (no silent data loss), but skips creating new defaults when vnext is enabledBackward Compatibility
scale:still work — settings are preservedscaleisomitemptyin both Go struct and JSON schema — no schema changes neededservice_target_agent.go:861) already handles nil Scale gracefullyTesting