-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Eng] Improve typespec devexp with New-DevTSPModule
#28954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VeryEarly
wants to merge
27
commits into
Azure:main
Choose a base branch
from
VeryEarly:yabo/tsp-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
598f2c4
init update tsp
VeryEarly b62eb3c
basic features
VeryEarly d563459
finish local test and add readme.md
VeryEarly d214897
update readme.md
VeryEarly 31dc9b1
update readme.md
VeryEarly 7bc1936
resolve AI comments and fix typo
VeryEarly 8483e3b
improve build script
VeryEarly 0bb2931
rename update-devtspmodule to new-devtspmodule
VeryEarly 511db29
update build script to use New-DevTSPModule instead of tsp-client
VeryEarly 69b896a
pipeline test
VeryEarly eda8d96
Merge remote-tracking branch 'Azure/main' into yabo/test-devtsp
VeryEarly 5602159
Merge remote-tracking branch 'Azure/main' into yabo/tsp-client
VeryEarly 01c0f89
correct comments
VeryEarly eeb0ba6
skip build/import azdev if imported
VeryEarly 472a27b
upgrade node version to 20.19.6
VeryEarly 4f37b14
add debug log for findnomcommand
VeryEarly d67ab9c
typo
VeryEarly 115af9b
typo
VeryEarly 58a939b
fix temp location
VeryEarly 20bff40
use local tsp
VeryEarly ad85937
list components under npm\prefix
VeryEarly 2b81f60
try fixing find command from path
VeryEarly 90f10d1
try fix
VeryEarly 90defe8
upgrade node versions for all
VeryEarly 2e4a42a
revert test changes
VeryEarly 9ec4193
Merge branch 'yabo/test-devtsp' into yabo/tsp-client
VeryEarly 2b5e93c
add changelog
VeryEarly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,7 +97,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install Autorest | ||
| inputs: | ||
| versionSpec: '18.20.8' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
@@ -107,11 +107,6 @@ jobs: | |
| targetType: inline | ||
| script: "$env:NODE_OPTIONS=\"--max-old-space-size=65536\"" | ||
| pwsh: true | ||
| - task: Npm@1 | ||
| displayName: Install tsp client | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g @azure-tools/[email protected] | ||
| - task: PowerShell@2 | ||
| displayName: 'Build' | ||
| inputs: | ||
|
|
@@ -212,7 +207,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install autorest | ||
| inputs: | ||
| versionSpec: '18.20.8' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install Autorest | ||
| inputs: | ||
| versionSpec: '18.20.8' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
@@ -57,11 +57,6 @@ jobs: | |
| targetType: inline | ||
| script: "$env:NODE_OPTIONS=\"--max-old-space-size=65536\"" | ||
| pwsh: true | ||
| - task: Npm@1 | ||
| displayName: Install tsp client | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g @azure-tools/[email protected] | ||
| - task: PowerShell@2 | ||
| displayName: 'Build' | ||
| inputs: | ||
|
|
@@ -107,7 +102,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install autorest | ||
| inputs: | ||
| versionSpec: '18.20.8' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install Autorest | ||
| inputs: | ||
| versionSpec: '18.20.7' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
@@ -37,11 +37,6 @@ jobs: | |
| targetType: inline | ||
| script: "$env:NODE_OPTIONS=\"--max-old-space-size=65536\"" | ||
| pwsh: true | ||
| - task: Npm@1 | ||
| displayName: Install tsp client | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g @azure-tools/[email protected] | ||
| - task: PowerShell@2 | ||
| displayName: 'Build' | ||
| inputs: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ steps: | |
| - task: NodeTool@0 | ||
| displayName: Install autorest | ||
| inputs: | ||
| versionSpec: '18.20.7' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
@@ -21,11 +21,6 @@ steps: | |
| targetType: inline | ||
| script: "$env:NODE_OPTIONS=\"--max-old-space-size=65536\"" | ||
| pwsh: true | ||
| - task: Npm@1 | ||
| displayName: Install tsp client | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g @azure-tools/[email protected] | ||
| - task: UseDotNet@2 | ||
| displayName: 'Use .NET SDK' | ||
| inputs: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install Autorest | ||
| inputs: | ||
| versionSpec: '18.20.8' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
@@ -53,11 +53,6 @@ jobs: | |
| targetType: inline | ||
| script: "$env:NODE_OPTIONS=\"--max-old-space-size=65536\"" | ||
| pwsh: true | ||
| - task: Npm@1 | ||
| displayName: Install tsp client | ||
| inputs: | ||
| command: custom | ||
| customCommand: install -g @azure-tools/[email protected] | ||
| - task: PowerShell@2 | ||
| displayName: 'Build' | ||
| inputs: | ||
|
|
@@ -103,7 +98,7 @@ jobs: | |
| - task: NodeTool@0 | ||
| displayName: Install autorest | ||
| inputs: | ||
| versionSpec: '18.20.8' | ||
| versionSpec: '20.19.6' | ||
| command: custom | ||
| verbose: false | ||
| customCommand: install autorest@latest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| $module = 'AzDev' | ||
| $artifacts = "$PSScriptRoot/../../artifacts" | ||
| $artifacts = Join-Path $PSScriptRoot ".." ".." "artifacts" | ||
| $moduleOut = Join-Path $artifacts $module | ||
|
|
||
| dotnet publish $PSScriptRoot/src --sc -o "$artifacts/$module/bin" | ||
| Copy-Item "$PSScriptRoot/$module/*" "$artifacts/$module" -Recurse -Force | ||
| if (Test-Path $moduleOut) { Remove-Item $moduleOut -Recurse -Force } | ||
| dotnet publish (Join-Path $PSScriptRoot "src") --sc -o (Join-Path $moduleOut "bin") | ||
| Copy-Item (Join-Path $PSScriptRoot $module "*") $moduleOut -Recurse -Force | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build script uses
Remove-Itemwith-Recurse -Forcewhich can have different behaviors on different platforms, particularly with symbolic links. Consider using a cross-platform compatible approach or adding error handling to gracefully handle platform-specific failures. Also ensure this works correctly on case-sensitive filesystems (Linux/macOS).