Skip to content

[AutoPR azure-mgmt-computerecommender]-generated-from-SDK Generation - Python-6760677 - #48781

Open
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sdkauto/azure-mgmt-computerecommender-6754980
Open

[AutoPR azure-mgmt-computerecommender]-generated-from-SDK Generation - Python-6760677#48781
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sdkauto/azure-mgmt-computerecommender-6754980

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Configurations: 'specification/compute/resource-manager/Microsoft.Compute/Recommender/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '397bf665c4d649b98bcfaf239c4b0a526301a03a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6760677 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36300 Submitted by: Yash.Khandelwal@microsoft.com

Copilot AI balanced review requested due to automatic review settings August 27, 2026 17:36
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 27, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the beta Compute Recommender management SDK to API version 2026-09-05-preview.

Changes:

  • Adds capacity-limit response models and enum.
  • Moves placement IDs to the response and removes deprecated capacity fields.
  • Updates generated metadata, API documentation, samples, and package version to 1.0.0b3.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Updates the specification commit.
generated_samples/operations_list_minimum_set_gen.py Updates sample source metadata.
generated_samples/operations_list_maximum_set_gen.py Updates sample source metadata.
generated_samples/get_spot_placement_scores.py Updates sample source metadata.
generated_samples/get_sku_mix_placement_scores.py Updates sample source metadata.
generated_samples/generate_spot_placement_scores.py Updates sample source metadata.
generated_samples/generate_sku_mix_placement_scores.py Updates sample source metadata.
CHANGELOG.md Documents the 1.0.0b3 release.
operations/_patch.py Applies generated formatting.
operations/_operations.py Updates API-version handling.
models/_patch.py Applies generated formatting.
models/_models.py Updates placement response models.
models/_enums.py Adds capacity-limit reasons.
models/__init__.py Exports the new model and enum.
aio/operations/_patch.py Applies generated formatting.
aio/operations/_operations.py Updates async API-version handling.
aio/_patch.py Applies generated formatting.
aio/_configuration.py Updates the async default API version.
aio/_client.py Updates async client documentation.
_version.py Bumps the package to 1.0.0b3.
_patch.py Applies generated formatting.
_configuration.py Updates the synchronous default API version.
_client.py Updates synchronous client documentation.
apiview-properties.json Maps the new public API types.
api.metadata.yml Updates API report metadata.
api.md Records the revised public API surface.
_metadata.json Updates generation versions and provenance.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings August 27, 2026 22:09
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-computerecommender]-generated-from-SDK Generation - Python-6754980 [AutoPR azure-mgmt-computerecommender]-generated-from-SDK Generation - Python-6756573 Aug 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 28, 2026 02:26
@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Review summary

Reviewed package sdk/computerecommender/azure-mgmt-computerecommender (client RecommenderMgmtClient).

Checks completed:

  • API version drift: unchanged (2026-09-05-preview at both first and latest revision).
  • Version consistency: _version.py (1.0.0b3) matches latest CHANGELOG.md entry (1.0.0b3).
  • Preview API version → beta SDK version: _metadata.json apiVersion contains preview, and _version.py correctly defines a beta version (1.0.0b3).
  • pyproject.toml stability flags: version contains b (preview) → is_stable = false and classifier "Development Status :: 4 - Beta" present, consistent.
  • Client signature: __init__ in _client.py has credential, subscription_id, base_url in the required order.
  • Client name consistency: RecommenderMgmtClient matches across _client.py, README.md, and pyproject.toml title.
  • Changelog date: latest release date (2026-08-27) is not more than 3 weeks in the future.
  • README code snippets: sample usage of RecommenderMgmtClient(credential=..., subscription_id=...) matches the actual client signature.

No violations of the authoritative MGMT SDK Code Review Rules were found for this revision.

@ChenxiJiang333

ChenxiJiang333 commented Aug 28, 2026

Copy link
Copy Markdown
Member

Hi Yash Khandelwal (@ykh015), SDK PR has been approved. You can move on to merge and release through the action suggestion in Release Plan.

Copilot AI review requested due to automatic review settings August 28, 2026 02:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 28, 2026 17:37
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-computerecommender]-generated-from-SDK Generation - Python-6756573 [AutoPR azure-mgmt-computerecommender]-generated-from-SDK Generation - Python-6760677 Aug 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants