Skip to content

[AutoPR azure-mgmt-oracledatabase]-generated-from-SDK Generation - Python-6764059 - #48787

Open
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sdkauto/azure-mgmt-oracledatabase-6755891
Open

[AutoPR azure-mgmt-oracledatabase]-generated-from-SDK Generation - Python-6764059#48787
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sdkauto/azure-mgmt-oracledatabase-6755891

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Configurations: 'specification/oracle/resource-manager/Oracle.Database/OracleDatabase/tspconfig.yaml', API Version: 2026-06-01, SDK Release Type: stable, and CommitSHA: '4e6e13d398d4c2616237322a62394fc4f1dfeb81' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6764059 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36309 Submitted by: v-mkidane@microsoft.com

Copilot AI balanced review requested due to automatic review settings August 27, 2026 20:02
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 27, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Regenerates the Oracle Database management SDK from the 2025-11-01-preview specification.

Changes:

  • Adds DB system data-collection options and regenerates tests/samples.
  • Raises minimum Python support to 3.10.
  • Updates generation metadata and package version to 3.1.0; however, the stable version conflicts with the preview API.

Reviewed changes

Copilot reviewed 275 out of 279 changed files in this pull request and generated 1 comment.

Show a summary per file

All paths are relative to sdk/oracledatabase/azure-mgmt-oracledatabase/.

File Description
tsp-location.yaml Updates TypeSpec source location and commit.
README.md Updates Python and authentication documentation.
pyproject.toml Updates supported Python versions.
generated_tests/test_oracle_database_mgmt_db_systems_operations.py Regenerates synchronous DB system test.
generated_tests/test_oracle_database_mgmt_db_systems_operations_async.py Regenerates asynchronous DB system test.
generated_samples/vm_clusters_remove_vms.py Updates generated sample provenance.
generated_samples/vm_clusters_list_private_ip_addresses.py Updates generated sample provenance.
generated_samples/vm_clusters_list_by_subscription.py Adds generated VM cluster sample.
generated_samples/vm_clusters_list_by_resource_group.py Adds generated VM cluster sample.
generated_samples/vm_clusters_get.py Adds generated VM cluster sample.
generated_samples/vm_clusters_delete.py Adds generated VM cluster sample.
generated_samples/vm_clusters_add_vms.py Updates generated sample provenance.
generated_samples/virtual_network_addresses_list_by_parent_minimum_set_gen.py Updates generated sample provenance.
generated_samples/virtual_network_addresses_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/virtual_network_addresses_get.py Adds generated address sample.
generated_samples/virtual_network_addresses_delete.py Adds generated address sample.
generated_samples/system_versions_list_by_location.py Adds generated system-version sample.
generated_samples/system_versions_list_by_location_minimum_set_gen.py Adds generated system-version sample.
generated_samples/system_versions_list_by_location_maximum_set_gen.py Adds generated system-version sample.
generated_samples/system_versions_get.py Adds generated system-version sample.
generated_samples/system_versions_get_minimum_set_gen.py Adds generated system-version sample.
generated_samples/system_versions_get_maximum_set_gen.py Adds generated system-version sample.
generated_samples/resource_anchors_list_by_subscription_minimum_set_gen.py Adds generated resource-anchor sample.
generated_samples/resource_anchors_list_by_subscription_maximum_set_gen.py Adds generated resource-anchor sample.
generated_samples/resource_anchors_list_by_resource_group_minimum_set_gen.py Adds generated resource-anchor sample.
generated_samples/resource_anchors_list_by_resource_group_maximum_set_gen.py Adds generated resource-anchor sample.
generated_samples/resource_anchors_get_maximum_set_gen.py Adds generated resource-anchor sample.
generated_samples/resource_anchors_delete_maximum_set_gen.py Adds generated resource-anchor sample.
generated_samples/oracle_subscriptions_update_maximum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_saas_subscription_details.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_saas_subscription_details_minimum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_saas_subscription_details_maximum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_cloud_account_details.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_cloud_account_details_minimum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_cloud_account_details_maximum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_by_subscription.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_list_by_subscription_minimum_set_gen.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_list_by_subscription_maximum_set_gen.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_list_activation_links.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_activation_links_minimum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_list_activation_links_maximum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_get.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_get_minimum_set_gen.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_get_maximum_set_gen.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_delete.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_delete_minimum_set_gen.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_delete_maximum_set_gen.py Adds generated subscription sample.
generated_samples/oracle_subscriptions_add_azure_subscriptions.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_add_azure_subscriptions_minimum_set_gen.py Updates generated sample provenance.
generated_samples/oracle_subscriptions_add_azure_subscriptions_maximum_set_gen.py Updates generated sample provenance.
generated_samples/operations_list.py Updates generated sample provenance.
generated_samples/operations_list_minimum_set_gen.py Updates generated sample provenance.
generated_samples/operations_list_maximum_set_gen.py Updates generated sample provenance.
generated_samples/network_anchors_list_by_subscription_minimum_set_gen.py Adds generated network-anchor sample.
generated_samples/network_anchors_list_by_subscription_maximum_set_gen.py Adds generated network-anchor sample.
generated_samples/network_anchors_list_by_resource_group_minimum_set_gen.py Adds generated network-anchor sample.
generated_samples/network_anchors_get_maximum_set_gen.py Adds generated network-anchor sample.
generated_samples/network_anchors_delete_maximum_set_gen.py Adds generated network-anchor sample.
generated_samples/gi_versions_list_by_location_minimum_set_gen.py Updates generated sample provenance.
generated_samples/gi_versions_list_by_location_maximum_set_gen.py Updates generated sample provenance.
generated_samples/gi_versions_get.py Adds generated GI-version sample.
generated_samples/gi_versions_get_minimum_set_gen.py Adds generated GI-version sample.
generated_samples/gi_versions_get_maximum_set_gen.py Adds generated GI-version sample.
generated_samples/gi_minor_versions_list_by_parent_minimum_set_gen.py Updates generated sample provenance.
generated_samples/gi_minor_versions_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/gi_minor_versions_get_maximum_set_gen.py Updates generated sample provenance.
generated_samples/flex_components_list_by_parent_minimum_set_gen.py Updates generated sample provenance.
generated_samples/flex_components_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/flex_components_get_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_update_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_list_by_subscription_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_list_by_subscription_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_list_by_resource_group_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_list_by_resource_group_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_get_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_get_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_delete_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_delete_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_create_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_storage_vaults_create_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_nodes_list_by_parent_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_nodes_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_nodes_action_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exascale_db_nodes_action_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exadb_vm_clusters_remove_vms_minimum_set_gen.py Updates generated sample provenance.
generated_samples/exadb_vm_clusters_remove_vms_maximum_set_gen.py Updates generated sample provenance.
generated_samples/exadb_vm_clusters_list_by_subscription_minimum_set_gen.py Adds generated ExaDB cluster sample.
generated_samples/exadb_vm_clusters_list_by_subscription_maximum_set_gen.py Adds generated ExaDB cluster sample.
generated_samples/exadb_vm_clusters_get_minimum_set_gen.py Adds generated ExaDB cluster sample.
generated_samples/exadb_vm_clusters_get_maximum_set_gen.py Adds generated ExaDB cluster sample.
generated_samples/exadb_vm_clusters_delete_minimum_set_gen.py Adds generated ExaDB cluster sample.
generated_samples/exadb_vm_clusters_delete_maximum_set_gen.py Adds generated ExaDB cluster sample.
generated_samples/exa_infra_list_by_subscription.py Adds generated Exadata infrastructure sample.
generated_samples/exa_infra_list_by_resource_group.py Adds generated Exadata infrastructure sample.
generated_samples/exa_infra_get.py Adds generated Exadata infrastructure sample.
generated_samples/exa_infra_delete.py Adds generated Exadata infrastructure sample.
generated_samples/exa_infra_add_storage_capacity.py Updates generated sample provenance.
generated_samples/dns_private_zones_list_by_location.py Adds generated DNS-zone sample.
generated_samples/dns_private_zones_get.py Adds generated DNS-zone sample.
generated_samples/dns_private_zones_get_minimum_set_gen.py Adds generated DNS-zone sample.
generated_samples/dns_private_zones_get_maximum_set_gen.py Adds generated DNS-zone sample.
generated_samples/dns_private_views_list_by_location.py Adds generated DNS-view sample.
generated_samples/dns_private_views_list_by_location_minimum_set_gen.py Adds generated DNS-view sample.
generated_samples/dns_private_views_list_by_location_maximum_set_gen.py Adds generated DNS-view sample.
generated_samples/dns_private_views_get.py Adds generated DNS-view sample.
generated_samples/dns_private_views_get_minimum_set_gen.py Adds generated DNS-view sample.
generated_samples/dns_private_views_get_maximum_set_gen.py Adds generated DNS-view sample.
generated_samples/db_versions_list_by_location_maximum_set_gen.py Updates generated sample provenance.
generated_samples/db_versions_get_maximum_set_gen.py Adds generated DB-version sample.
generated_samples/db_systems_list_by_subscription_minimum_set_gen.py Adds generated DB-system sample.
generated_samples/db_systems_list_by_subscription_maximum_set_gen.py Adds generated DB-system sample.
generated_samples/db_systems_list_by_resource_group_minimum_set_gen.py Adds generated DB-system sample.
generated_samples/db_systems_list_by_resource_group_maximum_set_gen.py Adds generated DB-system sample.
generated_samples/db_systems_get_maximum_set_gen.py Adds generated DB-system sample.
generated_samples/db_systems_delete_minimum_set_gen.py Adds generated DB-system sample.
generated_samples/db_systems_delete_maximum_set_gen.py Adds generated DB-system sample.
generated_samples/db_system_shapes_list_by_location.py Updates generated sample provenance.
generated_samples/db_system_shapes_list_by_location_minimum_set_gen.py Updates generated sample provenance.
generated_samples/db_system_shapes_list_by_location_maximum_set_gen.py Updates generated sample provenance.
generated_samples/db_system_shapes_get.py Adds generated DB-shape sample.
generated_samples/db_system_shapes_get_minimum_set_gen.py Adds generated DB-shape sample.
generated_samples/db_system_shapes_get_maximum_set_gen.py Adds generated DB-shape sample.
generated_samples/db_servers_list_by_parent_minimum_set_gen.py Updates generated sample provenance.
generated_samples/db_servers_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/db_servers_get.py Adds generated DB-server sample.
generated_samples/db_nodes_list_by_parent_minimum_set_gen.py Updates generated sample provenance.
generated_samples/db_nodes_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/db_nodes_get.py Adds generated DB-node sample.
generated_samples/db_nodes_get_maximum_set_gen.py Adds generated DB-node sample.
generated_samples/db_nodes_action.py Updates generated sample provenance.
generated_samples/db_nodes_action_minimum_set_gen.py Updates generated sample provenance.
generated_samples/db_nodes_action_maximum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_vm_clusters_remove_vms_minimum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_vm_clusters_remove_vms_maximum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_vm_clusters_list_private_ip_addresses_minimum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_vm_clusters_list_private_ip_addresses_maximum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_vm_clusters_list_by_subscription_minimum_set_gen.py Adds generated cloud VM sample.
generated_samples/cloud_vm_clusters_list_by_subscription_maximum_set_gen.py Adds generated cloud VM sample.
generated_samples/cloud_vm_clusters_get_minimum_set_gen.py Adds generated cloud VM sample.
generated_samples/cloud_vm_clusters_get_maximum_set_gen.py Adds generated cloud VM sample.
generated_samples/cloud_vm_clusters_delete_minimum_set_gen.py Adds generated cloud VM sample.
generated_samples/cloud_vm_clusters_delete_maximum_set_gen.py Adds generated cloud VM sample.
generated_samples/cloud_vm_clusters_add_vms_minimum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_vm_clusters_add_vms_maximum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_exadata_infrastructures_list_by_subscription_minimum_set_gen.py Adds generated infrastructure sample.
generated_samples/cloud_exadata_infrastructures_list_by_subscription_maximum_set_gen.py Adds generated infrastructure sample.
generated_samples/cloud_exadata_infrastructures_configure_exascale_minimum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_exadata_infrastructures_configure_exascale_maximum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_exadata_infrastructures_add_storage_capacity_minimum_set_gen.py Updates generated sample provenance.
generated_samples/cloud_exadata_infrastructures_add_storage_capacity_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_update_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_switchover_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_shrink_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_restore_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_list_by_subscription_minimum_set_gen.py Adds generated autonomous DB sample.
generated_samples/autonomous_databases_list_by_subscription_maximum_set_gen.py Adds generated autonomous DB sample.
generated_samples/autonomous_databases_list_by_resource_group_minimum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_list_by_resource_group_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_get_maximum_set_gen.py Adds generated autonomous DB sample.
generated_samples/autonomous_databases_generate_wallet_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_failover_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_delete_maximum_set_gen.py Adds generated autonomous DB sample.
generated_samples/autonomous_databases_change_disaster_recovery_configuration_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_databases_action_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_database_versions_list_by_location_minimum_set_gen.py Adds generated version sample.
generated_samples/autonomous_database_versions_list_by_location_maximum_set_gen.py Adds generated version sample.
generated_samples/autonomous_database_versions_get_minimum_set_gen.py Adds generated version sample.
generated_samples/autonomous_database_versions_get_maximum_set_gen.py Adds generated version sample.
generated_samples/autonomous_database_version_list_by_location.py Adds generated version sample.
generated_samples/autonomous_database_version_get.py Adds generated version sample.
generated_samples/autonomous_database_switchover.py Updates generated sample provenance.
generated_samples/autonomous_database_restore.py Updates generated sample provenance.
generated_samples/autonomous_database_national_character_set_list_by_location.py Adds generated character-set sample.
generated_samples/autonomous_database_national_character_set_get.py Adds generated character-set sample.
generated_samples/autonomous_database_list_by_subscription.py Adds generated autonomous DB sample.
generated_samples/autonomous_database_list_by_resource_group.py Updates generated sample provenance.
generated_samples/autonomous_database_get.py Adds generated autonomous DB sample.
generated_samples/autonomous_database_generate_wallet.py Updates generated sample provenance.
generated_samples/autonomous_database_failover.py Updates generated sample provenance.
generated_samples/autonomous_database_delete.py Adds generated autonomous DB sample.
generated_samples/autonomous_database_character_sets_get_minimum_set_gen.py Adds generated character-set sample.
generated_samples/autonomous_database_character_sets_get_maximum_set_gen.py Adds generated character-set sample.
generated_samples/autonomous_database_character_set_list_by_location.py Adds generated character-set sample.
generated_samples/autonomous_database_character_set_get.py Adds generated character-set sample.
generated_samples/autonomous_database_change_disaster_recovery_configuration.py Updates generated sample provenance.
generated_samples/autonomous_database_backups_update_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_database_backups_list_by_parent_maximum_set_gen.py Updates generated sample provenance.
generated_samples/autonomous_database_backup_patch.py Adds generated backup sample.
generated_samples/autonomous_database_backup_get.py Adds generated backup sample.
generated_samples/autonomous_database_backup_delete.py Adds generated backup sample.
CHANGELOG.md Records version and model additions.
azure/mgmt/oracledatabase/operations/_patch.py Applies generated formatting update.
azure/mgmt/oracledatabase/models/_patch.py Applies generated formatting update.
azure/mgmt/oracledatabase/aio/operations/_patch.py Applies generated formatting update.
azure/mgmt/oracledatabase/aio/_patch.py Applies generated formatting update.
azure/mgmt/oracledatabase/_version.py Bumps package version to 3.1.0.
azure/mgmt/oracledatabase/_patch.py Applies generated formatting update.
apiview-properties.json Adds cross-language API version metadata.
api.metadata.yml Adds API parser metadata.
_metadata.json Records preview API and generator versions.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@ChenxiJiang333

ChenxiJiang333 commented Aug 28, 2026

Copy link
Copy Markdown
Member

Hi Mihret Kidane (@mihretkidane-OCI), the package is configured as stable (version 3.1.0, is_stable = true), but _metadata.json targets preview API version 2025-11-01-preview. The release plan indicates stable API version 2026-06-01. Could you please provide context or regenerate the SDK with the aligned stable API version?

@mihretkidane-OCI

Copy link
Copy Markdown
Member

Hi Mihret Kidane (Mihret Kidane (@mihretkidane-OCI)), the package is configured as stable (version 3.1.0, is_stable = true), but _metadata.json targets preview API version 2025-11-01-preview. The release plan indicates stable API version 2026-06-01. Could you please provide context or regenerate the SDK with the aligned stable API version?

this should target 2026-06-01 stable version . We added the preview version because validation keeps failing in the spec repo

…e/OracleDatabase/tspconfig.yaml', API Version: 2026-06-01, SDK Release Type: stable, and CommitSHA: '4e6e13d398d4c2616237322a62394fc4f1dfeb81' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6764059 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI review requested due to automatic review settings August 31, 2026 02:37
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-oracledatabase]-generated-from-SDK Generation - Python-6755891 [AutoPR azure-mgmt-oracledatabase]-generated-from-SDK Generation - Python-6764059 Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 295 out of 324 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 31, 2026 02:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 295 out of 324 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 31, 2026 02:49
@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 295 out of 324 changed files in this pull request and generated 2 comments.

Comment thread sdk/oracledatabase/azure-mgmt-oracledatabase/api.metadata.yml
Comment thread sdk/oracledatabase/azure-mgmt-oracledatabase/pyproject.toml
Copilot AI review requested due to automatic review settings August 31, 2026 02:53
@ChenxiJiang333 ChenxiJiang333 removed the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 31, 2026
@github-actions

This comment has been minimized.

@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 295 out of 324 changed files in this pull request and generated no new comments.

Suppressed comments (1)

sdk/oracledatabase/azure-mgmt-oracledatabase/api.metadata.yml:1

  • This digest does not match the committed api.md (9a8f647c8a0e2eed8e50cc34b64582a0587e9da40254ea6627513edaf1151ccb). The API metadata consistency check uses this field, so the package will fail validation until the metadata is regenerated or the digest is corrected.

@ChenxiJiang333

ChenxiJiang333 commented Aug 31, 2026

Copy link
Copy Markdown
Member

Management SDK PR review

Severity Finding Location Evidence Rule Remediation
Blocking API version changed sdk/oracledatabase/azure-mgmt-oracledatabase/_metadata.json First revision e66358dde0dc985a64573a59713ba93713f69e12 had apiVersion: 2025-11-01-preview; latest revision d6e8cd4e20fff106c5dfa37f6da499d47c299cf8 has apiVersion: 2026-06-01 API version drift (deterministic check) Restore the original API version (2025-11-01-preview) for this PR, or explicitly explain the intentional API-version bump to 2026-06-01 and obtain reviewer approval before merging.

Unverified checks

Unverified checks: None.

Review summary

Affected package: sdk/oracledatabase/azure-mgmt-oracledatabase.

Checks completed:

  • Version consistency: _version.py (VERSION = "4.0.0") matches the latest CHANGELOG.md entry (## 4.0.0 (2026-08-31)).
  • Preview API version vs. SDK version: latest _metadata.json apiVersion (2026-06-01) is stable (not preview), consistent with the stable SDK version 4.0.0.
  • Changelog date: release date 2026-08-31 is not more than 3 weeks in the future from today.
  • pyproject.toml stability flags: version has no b suffix (stable) → is_stable = true and classifier "Development Status :: 5 - Production/Stable" both present, consistent.
  • Client signature: OracleDatabaseMgmtClient.__init__ in _client.py has credential, subscription_id, base_url in the required order; subscription_id is present so no_sub is not required.
  • Client name consistency: _client.py class name, README.md usage, and pyproject.toml title are all OracleDatabaseMgmtClient.
  • README code snippets: the authentication sample matches the actual client constructor signature.
  • API version drift (this PR): flagged above as Blocking — the metadata API version changed between the first and latest PR revisions.

This is an advisory review only; no approval, merge, or label state has been changed.

target api version 2026-06-01: #48787 (comment)

@ChenxiJiang333

ChenxiJiang333 commented Aug 31, 2026

Copy link
Copy Markdown
Member

Hi Mihret Kidane (@mihretkidane-OCI), SDK PR has been approved. You can move on to merge and release through the action suggestion in Release Plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants