[Evaluation] Make App Insights export best effort for managed identity - #48805
Merged
Mohamed Hessien (m7md7sien) merged 3 commits intoSep 1, 2026
Conversation
github-actions
Bot
added
the
Evaluation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Mohamed Hessien (m7md7sien)
force-pushed
the
fix/evaluation-app-insights-export-best-effort
branch
from
August 31, 2026 01:24
6b0d837 to
510a61c
Compare
Keep managed-identity evaluation results when Application Insights export fails or times out, while preserving strict credential validation and failure logs. Authored-by: GitHub Copilot for VS Code Model: GitHub Copilot (copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mohamed Hessien (m7md7sien)
force-pushed
the
fix/evaluation-app-insights-export-best-effort
branch
from
August 31, 2026 01:31
510a61c to
41dd877
Compare
Copilot started reviewing on behalf of
Mohamed Hessien (m7md7sien)
August 31, 2026 01:34
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Makes managed-identity Application Insights telemetry export best-effort so export failures do not fail evaluations.
Changes:
- Logs exporter, asynchronous export, and flush failures.
- Avoids false success logs while preserving strict configuration validation.
- Adds regression tests and release notes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_evaluate.py |
Handles telemetry export failures without propagation. |
test_evaluate.py |
Covers success, failure, timeout, and shutdown behavior. |
CHANGELOG.md |
Documents the best-effort export fix. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Rabah B (RabsB)
marked this pull request as ready for review
August 31, 2026 01:42
Rabah B (RabsB)
approved these changes
Aug 31, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Mohamed Hessien (m7md7sien)
August 31, 2026 19:51
View session
…elog entry Verify ChangeLogEntries failed: _version.py still read 1.18.4, so the validator picked up the 1.18.4 entry and rejected its 2026-08-27 date for no longer being the latest in the file, now that a 1.18.5 (Unreleased) section sits above it. _version.py represents the upcoming version and has to match the Unreleased heading. This is the repository convention: of the packages currently carrying an (Unreleased) top entry, 71 have a matching _version.py and 2 do not. Authored-by: GitHub Copilot for VS Code Model: Claude Opus 5 (claude-opus-5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Mohamed Hessien (m7md7sien)
August 31, 2026 19:55
View session
Mohamed Hessien (m7md7sien)
enabled auto-merge (squash)
August 31, 2026 23:39
Rabah B (RabsB)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Application Insights export is a telemetry side effect and should not determine whether an evaluation succeeds. This change makes the ProjectManagedIdentity path best-effort, consistent with the existing API-key path.
Internal tracking: Microsoft ADO Bug 5571803.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
This pull request was prepared with assistance from GitHub Copilot for VS Code.