[typespec-ts] fix platform import issue for customization#4585
Open
kazrael2119 wants to merge 10 commits into
Open
[typespec-ts] fix platform import issue for customization#4585kazrael2119 wants to merge 10 commits into
kazrael2119 wants to merge 10 commits into
Conversation
kazrael2119
requested review from
JialinHuang803,
MaryGao,
maorleger and
qiaozha
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:typescript
Collaborator
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
commit: |
Contributor
⚡ Benchmark Results
Full details – comparing
|
| Metric | Baseline | Current | Change |
|---|---|---|---|
| total | 🔴 675.6ms | 🔴 730.8ms | +8.2% 🔴 |
| loader | 🟢 155.1ms | 🟡 201.3ms | +29.8% 🔴 |
| resolver | 🟢 19.1ms | 🟢 17.9ms | -6.2% 🟢 |
| checker | 🟡 214.2ms | 🟡 250.5ms | +17.0% 🔴 |
| validation | 🟢 50.5ms | 🟢 47.3ms | -6.3% 🟢 |
| ↳ validation/@azure-tools/typespec-azure-core | 🟢 7.2ms | 🟢 7.4ms | +3.9% |
| ↳ validation/@typespec/http | 🟢 7.6ms | 🟢 6.4ms | -15.8% 🟢 |
| ↳ validation/@typespec/rest | 🟢 0.8ms | 🟢 0.6ms | -26.0% |
| ↳ validation/@typespec/versioning | 🔴 32.2ms | 🔴 30.8ms | -4.4% |
| ↳ validation/compiler | 🟢 1.8ms | 🟢 1.7ms | -8.4% |
| linter | 🟢 168.5ms | 🟢 149.5ms | -11.3% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-core/auth-required | 🟢 0.0ms | 🟢 0.0ms | -32.2% |
| ↳ linter/@azure-tools/typespec-azure-core/bad-record-type | 🟢 0.3ms | 🟢 0.2ms | -21.2% |
| ↳ linter/@azure-tools/typespec-azure-core/byos | 🟢 6.9ms | 🟢 6.3ms | -8.7% |
| ↳ linter/@azure-tools/typespec-azure-core/casing-style | 🟢 0.7ms | 🟢 0.6ms | -0.2% |
| ↳ linter/@azure-tools/typespec-azure-core/composition-over-inheritance | 🟢 0.1ms | 🟢 0.1ms | -15.6% |
| ↳ linter/@azure-tools/typespec-azure-core/documentation-required | 🟢 1.0ms | 🟢 0.9ms | -12.8% |
| ↳ linter/@azure-tools/typespec-azure-core/friendly-name | 🟢 0.8ms | 🟢 0.6ms | -22.4% |
| ↳ linter/@azure-tools/typespec-azure-core/key-visibility-required | 🟢 0.2ms | 🟢 0.2ms | -6.4% |
| ↳ linter/@azure-tools/typespec-azure-core/known-encoding | 🟢 0.3ms | 🟢 0.3ms | +2.8% |
| ↳ linter/@azure-tools/typespec-azure-core/long-running-polling-operation-required | 🟢 0.4ms | 🟢 0.3ms | -10.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-case-mismatch | 🟢 0.3ms | 🟢 0.3ms | -9.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-closed-literal-union | 🟢 0.4ms | 🟢 0.3ms | -32.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-enum | 🟢 0.1ms | 🟢 0.0ms | -22.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-error-status-codes | 🟢 0.1ms | 🟢 0.1ms | -9.6% |
| ↳ linter/@azure-tools/typespec-azure-core/no-explicit-routes-resource-ops | 🟢 0.1ms | 🟢 0.1ms | -15.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-format | 🟢 0.7ms | 🟢 0.5ms | -20.3% |
| ↳ linter/@azure-tools/typespec-azure-core/no-generic-numeric | 🟢 0.5ms | 🟢 0.4ms | -13.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-header-explode | 🔴 21.7ms | 🔴 21.7ms | -0.1% |
| ↳ linter/@azure-tools/typespec-azure-core/no-legacy-usage | 🟢 1.2ms | 🟢 1.2ms | -0.8% |
| ↳ linter/@azure-tools/typespec-azure-core/no-multiple-discriminator | 🟢 0.1ms | 🟢 0.1ms | -13.2% |
| ↳ linter/@azure-tools/typespec-azure-core/no-nullable | 🟢 0.3ms | 🟢 0.3ms | -12.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-offsetdatetime | 🟢 1.3ms | 🟢 1.2ms | -7.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-openapi | 🟢 2.3ms | 🟢 1.9ms | -16.8% |
| ↳ linter/@azure-tools/typespec-azure-core/no-private-usage | 🟢 2.4ms | 🟢 1.9ms | -20.5% |
| ↳ linter/@azure-tools/typespec-azure-core/no-query-explode | 🔴 23.9ms | 🔴 24.4ms | +2.3% |
| ↳ linter/@azure-tools/typespec-azure-core/no-response-body | 🔴 26.8ms | 🔴 27.8ms | +3.7% |
| ↳ linter/@azure-tools/typespec-azure-core/no-rest-library-interfaces | 🟢 0.0ms | 🟢 0.0ms | -33.4% |
| ↳ linter/@azure-tools/typespec-azure-core/no-route-parameter-name-mismatch | 🟢 5.5ms | 🟢 5.8ms | +5.3% |
| ↳ linter/@azure-tools/typespec-azure-core/no-rpc-path-params | 🟢 0.2ms | 🟢 0.2ms | +0.9% |
| ↳ linter/@azure-tools/typespec-azure-core/no-string-discriminator | 🟢 0.1ms | 🟢 0.0ms | -22.0% |
| ↳ linter/@azure-tools/typespec-azure-core/no-unknown | 🟢 0.2ms | 🟢 0.2ms | -12.9% |
| ↳ linter/@azure-tools/typespec-azure-core/no-unnamed-union | 🟢 0.5ms | 🟢 0.4ms | -28.1% |
| ↳ linter/@azure-tools/typespec-azure-core/operation-missing-api-version | 🟢 0.2ms | 🟢 0.2ms | -31.0% |
| ↳ linter/@azure-tools/typespec-azure-core/request-body-problem | 🟢 0.3ms | 🟢 0.3ms | +2.1% |
| ↳ linter/@azure-tools/typespec-azure-core/require-versioned | 🟢 0.0ms | 🟢 0.0ms | -37.9% |
| ↳ linter/@azure-tools/typespec-azure-core/response-schema-problem | 🔴 25.5ms | 🔴 25.7ms | +0.9% |
| ↳ linter/@azure-tools/typespec-azure-core/rpc-operation-request-body | 🟢 0.3ms | 🟢 0.4ms | +5.6% |
| ↳ linter/@azure-tools/typespec-azure-core/spread-discriminated-model | 🟢 0.3ms | 🟢 0.3ms | -6.3% |
| ↳ linter/@azure-tools/typespec-azure-core/use-standard-names | 🟢 7.0ms | 🟢 6.4ms | -7.6% |
| ↳ linter/@azure-tools/typespec-azure-core/use-standard-operations | 🟢 0.2ms | 🟢 0.1ms | -10.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources | 🟢 4.9ms | 🟢 4.4ms | -9.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-lifecycle-operations | 🟢 0.0ms | 🟢 0.0ms | -13.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-common-types-version | 🟢 4.9ms | 🟢 4.2ms | -13.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key | 🟢 0.1ms | 🟢 0.1ms | -10.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage | 🟢 0.1ms | 🟢 0.1ms | -19.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes | 🟢 2.1ms | 🟢 1.2ms | -41.3% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-path-casing-conflicts | 🔴 27.7ms | 🟢 4.6ms | -83.3% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-record | 🟢 0.4ms | 🟢 0.4ms | -6.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes | 🟢 0.5ms | 🟢 0.5ms | -9.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes | 🟢 0.0ms | 🟢 0.0ms | -53.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-action-no-segment | 🟢 0.3ms | 🟢 0.2ms | -28.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property | 🟢 0.1ms | 🟢 0.1ms | -6.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator | 🟢 0.0ms | 🟢 0.0ms | -35.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-action-verb | 🟢 0.1ms | 🟢 0.1ms | -24.4% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property | 🟢 0.1ms | 🟢 0.1ms | -23.0% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-version-format | 🟢 0.1ms | 🟢 0.0ms | -24.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-key-invalid-chars | 🟢 0.3ms | 🟢 0.3ms | +1.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-name-pattern | 🟢 0.0ms | 🟢 0.0ms | -45.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation | 🟢 0.2ms | 🟢 0.2ms | -25.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation-response | 🟢 5.7ms | 🟢 4.7ms | -16.3% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-patch | 🟢 0.4ms | 🟢 0.3ms | -18.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-path-segment-invalid-chars | 🟢 0.2ms | 🟢 0.2ms | -12.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state | 🟢 0.1ms | 🟢 0.1ms | -23.6% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/beyond-nesting-levels | 🟢 0.1ms | 🟢 0.1ms | -19.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/empty-updateable-properties | 🟢 0.2ms | 🟢 0.2ms | +4.4% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/improper-subscription-list-operation | 🟢 0.0ms | 🟢 0.0ms | -41.7% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header | 🟡 14.9ms | 🟡 14.6ms | -2.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-operations-endpoint | 🟢 0.0ms | 🟢 0.0ms | -35.3% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers | 🟢 0.4ms | 🟢 0.3ms | -19.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-empty-model | 🟢 0.1ms | 🟢 0.1ms | +0.2% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-override-props | 🟢 0.1ms | 🟢 0.1ms | -24.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation | 🟢 0.2ms | 🟢 0.2ms | -2.9% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body | 🔴 23.5ms | 🔴 22.1ms | -5.7% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/patch-envelope | 🟢 0.2ms | 🟢 0.2ms | +3.1% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/resource-name | 🟢 0.2ms | 🟢 0.2ms | -1.5% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/secret-prop | 🟢 8.4ms | 🟢 2.3ms | -72.6% 🟢 |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/unsupported-type | 🟢 0.4ms | 🟢 0.4ms | -3.8% |
| ↳ linter/@azure-tools/typespec-azure-resource-manager/version-progression | 🟢 0.0ms | 🟢 0.0ms | -25.1% |
| ↳ linter/@azure-tools/typespec-client-generator-core/property-name-conflict | 🟢 1.3ms | 🟢 1.2ms | -9.0% |
| ↳ linter/@azure-tools/typespec-client-generator-core/require-client-suffix | 🟢 0.3ms | 🟢 0.2ms | -28.8% |
| emit | 🔴 5.77s | 🔴 5.84s | +1.1% |
| ↳ emit/@azure-tools/typespec-autorest | 🟢 185.1ms | 🟢 170.7ms | -7.8% 🟢 |
| ↳ emit/@azure-tools/typespec-python | 🔴 4.32s | 🔴 4.59s | +6.2% 🔴 |
| ↳ emit/@typespec/http-client-js | 🔴 1.06s | 🔴 863.3ms | -18.3% 🟢 |
| ↳ emit/@typespec/openapi3 | 🟢 163.9ms | 🟢 156.0ms | -4.8% |
| ↳ emit/@typespec/openapi3/compute | 🟢 143.4ms | 🟢 136.7ms | -4.7% |
| ↳ emit/@typespec/openapi3/write | 🟢 20.3ms | 🟢 18.9ms | -6.6% 🟢 |
Averaged across 3 specs (azure-arm-resource-manager, azure-core-dataplane, azure-full).
Threshold: changes > ±5% are highlighted.
🟢 Fast · 🟡 Moderate (stages >200ms, rules >10ms) · 🔴 Slow (stages >400ms, rules >20ms)
Collaborator
|
You can try these changes here
|
Member
|
@kazrael2119 maybe as part of this PR, we could get rid of the |
Member
|
Maybe we can remove |
kazrael2119
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
| }; | ||
| } | ||
|
|
||
| packageInfo.dependencies = { |
Member
There was a problem hiding this comment.
I am not quite certain about this. Did we do batch update on the existing sdks to bump these dependency versions? If so, do we still need to update here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4581