Update usbd_custom_hid_if.c - #9
Open
MouseOfMadness wants to merge 1 commit into
Open
Conversation
Fix for incorrect values. Looks like the two sections for slider inputs were copy/pasted and both ended up being identified with the same value 0x36 so changed the second to 0x37. Also looks like the pointer values on lines 140 and 151 were also mistakenly set to 0x36 in the process. Corrected to match usage on lines 114 and 127 Could be root cause of improper HID reporting on linux systems
|
This seems to work, thanks for your contribution. Please check the attachment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for incorrect values. Looks like the two sections for slider inputs were copy/pasted and both ended up being identified with the same value 0x36 so changed the second to 0x37. All other axes had unique values from 0x30 to 0x35 so updated to be consistent. Also looks like the pointer values on lines 140 and 151 were also mistakenly set to 0x36 in the process. Corrected to match usage on lines 114 and 127 back to 0x01
Could be root cause of improper HID reporting on linux systems.
All other line changes result of github changing encoding on special characters.