Conversation
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
391c93a to
b55da76
Compare
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
a5bea01 to
a4dc9d0
Compare
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
ebe1d22 to
98d4efa
Compare
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
5e4290a to
6a7b91c
Compare
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
5c9154b to
2155865
Compare
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
94c318a to
6ad5b2a
Compare
Cudok
requested review from
veronikarichter
and removed request for
veronikarichter
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
71cc31c to
e497971
Compare
Idea: have an eye an the status of this issue with ifcTester
is working
include maybe later
but Error when getting information for file
including some test files
comment out stuff and change run call
filecomp fits not because order of html is randomly
is running and structured
remove not needed comment blocks and print commands
only elements with static names will be checked
from "inst" template
regression py3.11 3.10 integration py3.11
and add ids_file_path to sim_settings.py
Cudok
force-pushed
the
170-ifc_check_via_IDS
branch
from
e497971 to
1b720ca
Compare
veronikarichter
left a comment
veronikarichter
left a comment
There was a problem hiding this comment.
Thank you for your work @Cudok !
I added several comments for minor things to change and improve. I was not able yet to fully review the check_ifc.py changes due to time constraints, but I will do it in the next round of review.
| def run_simple_project(): | ||
| """Run a bim2sim project with the PluginIFCCheck | ||
|
|
||
| This exmaple is used while the development of the ifc check based on IDS |
There was a problem hiding this comment.
| This exmaple is used while the development of the ifc check based on IDS | |
| This example is used while the development of the ifc check based on IDS |
| task. After the development is finished, it can deleted or use as example | ||
| for the usage of this task. |
There was a problem hiding this comment.
Since you opened a pull request, I assume the development of the IfcCheck is finalized. Please update the example accordingly so it can be used as a proper example for exploring the usage of the IfcCheck.
| # Create a temp directory for the project, feel free to use a "normal" | ||
| # directory | ||
| project_path = Path(tempfile.TemporaryDirectory( | ||
| prefix='bim2sim_e1_checkifc').name) |
There was a problem hiding this comment.
| prefix='bim2sim_e1_checkifc').name) | |
| prefix='bim2sim_e1_checkifc_').name) |
I would suggest to end the prefix with an underscore, so it is easier to read afterwards.
| # ifc_file = test_rsrc_path / 'ids/fail-a_minimal_ids_can_check_a_minimal_ifc_1_2.ifc' | ||
| # test_rsrc_path = Path(__file__).parent.parent.parent.parent / 'resources' | ||
| # |
There was a problem hiding this comment.
Please remove obsolete lines.
| # | ||
| # ifc file with not fitting ifc version | ||
| # ifc_paths = { | ||
| # IFCDomain.arch: | ||
| # Path(bim2sim.__file__).parent.parent / | ||
| # 'test/resources/arch/ifc/AC20-FZK-Haus_ifc23.ifc', | ||
| # } |
There was a problem hiding this comment.
Remove or add in another example?
| all_errors=all_errors)) | ||
| out_file.close() | ||
| if show_report: | ||
| # can comment out, if not the browser should show the report |
There was a problem hiding this comment.
please rewrite this comment
| summary_props=summary_props)) | ||
| out_file.close() | ||
| if show_report: | ||
| # can comment out, if not the browser should show the report |
There was a problem hiding this comment.
rewrite, please also apply to other similar comments
| mandatory=True | ||
| ) | ||
|
|
||
| ids_file_path = PathSetting( |
There was a problem hiding this comment.
Add this to the plugin-specific simsettings.
| "ifctester==0.8.1", | ||
| "pystache==0.6.8" # is a dependency from ifctester, not automatically install here |
There was a problem hiding this comment.
Shouldn't these rather be added as plugin-specific requirements below?
| path = test/resources | ||
| url = https://github.com/BIM2SIM/bim2sim-test-resources.git | ||
| branch = main | ||
| branch = 15-update_test_resources_ifccheck |
There was a problem hiding this comment.
change this back to main after review and merge of the test resources.
2 participants
implementation of ifc check include IDS support