fix: use the public bmf.hmp Python namespace in llm_caption demo - #218
Merged
Conversation
The HML package namespace was renamed to HMP and is not included in the Python distribution. Update the LLM caption demo to import the packaged module.
HuHeng
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
llm_captiondemo importsbmf.hml.hmp, which is a stale reference to the old HML namespace. That namespace was renamed to HMP (commitf087e0d) and is not included in the Python distribution, so the import fails at runtime.Change
bmf.hmpis the packaged, public module (declared insetup.pyand re-exported bybmf/__init__.py), and is what every other demo/test already uses.Verification
python3 -m py_compile bmf/demo/llm_caption/llm_caption.pygit grep -i 'bmf.hml.hmp'— 0 remaining references in the repo