GS Cleanup + depth renderer + more tests #17544

CedricGuillemet · 2025-12-08T16:32:07Z

removed viewDirectionFactor uniform
more explicit eyeToSplatLocalSpace name
more consistent Y scaling: keep data unchanged and change scaling.y at loading time
add options to updateData to preserve back compat
update spz v3 scene accordingly
removed invy matrix usage in shaders
depth renderer : https://playground.babylonjs.com/#V80DRL#12
loadFileAsync now loads more format as it uses ImportMeshAsync internally
4 new tests

bjsplat · 2025-12-08T16:37:10Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-12-08T16:51:42Z

Snapshot stored with reference name:
refs/pull/17544/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17544/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17544/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17544/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge#BCU1XR#0

bjsplat · 2025-12-08T16:58:14Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-08T16:59:09Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-08T17:11:44Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-08T17:24:23Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-09T15:03:25Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-12-09T15:18:37Z

Snapshot stored with reference name:
refs/pull/17544/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17544/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17544/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17544/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2025-12-09T15:23:54Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-09T15:31:15Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-09T15:40:22Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-09T15:59:30Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-10T09:14:52Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-10T09:19:47Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-10T09:33:26Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-10T09:37:47Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-10T09:58:50Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-10T10:04:03Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-10T10:11:59Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-10T10:17:05Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-10T10:41:02Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-10T10:44:00Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-12T15:36:15Z

Snapshot stored with reference name:
refs/pull/17544/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17544/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17544/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17544/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17544/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2025-12-12T15:40:32Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-12T15:44:29Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-12T16:07:07Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-12T16:23:07Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-15T09:30:45Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-15T09:33:45Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-15T09:44:52Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-15T09:59:44Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-15T10:30:52Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-15T10:40:39Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-15T10:46:30Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-15T10:49:21Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-15T11:15:43Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-15T11:17:01Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-15T11:22:55Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-15T11:31:05Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

packages/dev/core/src/Materials/GaussianSplatting/gaussianSplattingMaterial.ts

bjsplat · 2025-12-15T13:26:00Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-15T13:28:39Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-15T13:37:39Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-15T13:39:01Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17544/merge/testResults/webgl2playwright/index.html

Remove viewDirection for GS SH

d31c2e0

CedricGuillemet changed the title ~~Remove viewDirection for GS SH~~ Remove viewDirectionFactor for GS SH Dec 8, 2025

CedricGuillemet added 2 commits December 9, 2025 15:57

removed invY shader matrix

b64c24d

vector naming

3e7c287

CedricGuillemet mentioned this pull request Dec 9, 2025

Gaussian Splatting Updates #16671

Open

13 tasks

Y flip clean up

fdd54e2

y flip spz

7449753

spz v3 rotation

826ec16

update tests

9c1c718

fix webgpu

805197c

rendercount

79584d0

CedricGuillemet marked this pull request as ready for review December 15, 2025 11:27

CedricGuillemet requested a review from Popov72 December 15, 2025 12:17

Popov72 reviewed Dec 15, 2025

View reviewed changes

packages/dev/core/src/Materials/GaussianSplatting/gaussianSplattingMaterial.ts Outdated Show resolved Hide resolved

naming

0c2213e

Popov72 approved these changes Dec 15, 2025

View reviewed changes

CedricGuillemet merged commit e9a291b into BabylonJS:master Dec 15, 2025
20 checks passed

GS Cleanup + depth renderer + more tests #17544

GS Cleanup + depth renderer + more tests #17544

Uh oh!

Conversation

CedricGuillemet commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 9, 2025

Uh oh!

bjsplat commented Dec 9, 2025

Uh oh!

bjsplat commented Dec 9, 2025

Uh oh!

bjsplat commented Dec 9, 2025

Uh oh!

bjsplat commented Dec 9, 2025

Uh oh!

bjsplat commented Dec 9, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

bjsplat commented Dec 12, 2025

Uh oh!

bjsplat commented Dec 12, 2025

Uh oh!

bjsplat commented Dec 12, 2025

Uh oh!

bjsplat commented Dec 12, 2025

Uh oh!

bjsplat commented Dec 12, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

Uh oh!

bjsplat commented Dec 15, 2025

CedricGuillemet commented Dec 8, 2025 •

edited

Loading