Skip to content

Conversation

@georginahalpern
Copy link
Contributor

  • getCollisionOffset is applied to center and position simultaneously so that the orientation remains the same (yaw/pitch/radius)
  • camera extension can override _getCollisionOffset if wanting to customize collision logic, or a camera user can update collisionOffset property in the afterCheckInputsObservable
  • only recalculate center after a drag so that the center is not continually changing during a zoomToCursor movement (causing slight jitter)

@georginahalpern georginahalpern changed the title [GeospatialCamera] Add surfaceCollision logic that can be overridden. Fix center recalculation [GeospatialCamera] Add surfaceCollision logic. Fix center recalculation Dec 12, 2025
@georginahalpern georginahalpern changed the title [GeospatialCamera] Add surfaceCollision logic. Fix center recalculation [GeospatialCamera] Add overrideable surfaceCollision logic. Fix center recalculation Dec 12, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2025

Snapshot stored with reference name:
refs/pull/17551/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17551/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17551/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17551/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17551/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17551/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17551/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17551/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants