DELIVERY: a green check proves something about where it ran - #17
Open
arnelirobles wants to merge 1 commit into
Open
DELIVERY: a green check proves something about where it ran#17arnelirobles wants to merge 1 commit into
arnelirobles wants to merge 1 commit into
Conversation
Two silent passes from the umbraco-pwa work on 2 September, same shape both times. A 4KB request body cap that nothing enforced in the suite, because RequestSizeLimit only sets IHttpMaxRequestBodySizeFeature and TestServer does not implement it, so the attribute was inert and an oversized body came back 202 while three documents stated the cap. Then a mutation check that could not see its own mutation, because gitleaks detect scans commits and the password under test was uncommitted. The scan was clean and the allowlist looked proven. Both exited zero with a real runner. The thing under test was outside the scope the runner was looking at.
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One section, because both incidents are the same shape.
What it caught
A 4KB request body cap that nothing enforced in the suite.
[RequestSizeLimit]does not reject anything itself, it setsIHttpMaxRequestBodySizeFeature, and Kestrel is what reads it. The integration suite runs onWebApplicationFactory, so it serves over TestServer, and TestServer does not implement that feature. The attribute was inert and an 8KB body came back202.SECURITY.md,THREAT-MODEL.mdand the controller's own remarks all stated the cap. Any test written for it in that suite would have passed while asserting nothing.An hour later, a mutation check that could not see its own mutation. A gitleaks allowlist had been widened, and widening one far enough to disable the rule looks identical to widening it correctly, so the rule was tested by putting a real-looking password in the file. Clean scan, allowlist apparently proven.
gitleaks detectscans commits; the password was uncommitted and never examined.--no-gitscans files, and with it the rule fired at once.Why one section rather than two
Both had a real runner, a zero exit, and the thing under test sitting outside the scope the runner was reading. The section ends on the question that subsumes the rest, which is whether deliberately breaking the thing turns the check red, and notes that it is the one most often skipped because by then the work feels finished.
That last point is not rhetorical. The second incident happened to someone who had spent the previous hour writing about the first.
Note
This is a sixth open DELIVERY pull request (#10, #11, #12, #14, #15, #16 are the others). Worth deciding whether the backlog wants clearing before it grows again.