Clear the dependency advisories that turned the audit red - #13
Merged
Conversation
The audit job has failed since at least 15 August on five advisories, all of them reaching test projects only. No shipped package was affected. xunit 2.4.2 and Test.Sdk 17.6.0 still pulled the .NET Standard 1.x shims System.Net.Http 4.3.0 and System.Text.RegularExpressions 4.3.0. The other two came from Microsoft.Data.Sqlite and Mvc.Testing sitting on 8.0.0. Nothing in this repository changed to cause it. The advisories were published against dependencies that were already there.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughUpdated testing and supporting package versions in 13 test project files. Existing package asset settings and selected unchanged dependencies remain intact. ChangesTest dependency updates
Merge Risk: ⚪ Minimal · up to This change updates dependencies used by test projects to clear audit advisories without affecting shipped packages. No actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dependency auditjob has been failing since at least 15 August. Every other job passes: build and test are green on both Windows and Ubuntu, the core-stays-dependency-free check passes, formatting passes.No shipped package was affected
Checked before changing anything:
All five advisories reached test projects only. Anyone consuming Mapsicle from NuGet was never exposed. The problem was a red build, not a vulnerable release.
What was actually wrong
System.Net.Http4.3.0System.Text.RegularExpressions4.3.0SQLitePCLRaw.lib.e_sqlite32.1.6Microsoft.Data.Sqlite8.0.0System.Text.Json8.0.0Microsoft.AspNetCore.Mvc.Testing8.0.0The first two are the .NET Standard 1.x compatibility shims that old xunit still dragged in. Modern xunit dropped them. The other two were patch-zero packages that have had thirty patches published since.
Nothing in this repository changed to cause the failure. The advisories were published against dependencies that were already sitting there, which is why there is no commit behind the first red run.
Verified, running CI's exact command
And the whole suite:
Two follow-ups worth opening separately
Central Package Management. These versions are declared independently in 13
.csprojfiles, which is why one bump touched thirteen places and why they had drifted (coverlet.collectorwas at 6.0.0 in seven projects and 6.0.4 in one). ADirectory.Packages.propsmakes the next advisory a one-line change.The audit will go red again. It is
NuGetAuditMode=allwithTreatWarningsAsErrors=true, so any advisory published against any transitive dependency of any project fails the build, with no commit behind it. That is a defensible choice for a package with this many downloads, but it means the job is a scheduled maintenance obligation rather than a gate on the diff. Worth either running it on a schedule as well as on PRs, so it is noticed on its own terms, or scoping the failure to shipped projects and reporting test-only advisories as warnings.Summary by CodeRabbit